Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3837)

Unified Diff: chrome/browser/BUILD.gn

Issue 2457443004: Build some x11 dependent files only if 'use_x11' (Closed)
Patch Set: Build some x11 dependent files if 'use_x11' Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 72e5b53f13124d3530cd930692220808645f0cb3..744395c4566b5e95c71ca5a8ed8f7a5455c67aa4 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -3498,20 +3498,29 @@ split_static_library("browser") {
"first_run/upgrade_util.cc",
"first_run/upgrade_util_linux.cc",
"first_run/upgrade_util_linux.h",
- "fullscreen_aurax11.cc",
"icon_loader_auralinux.cc",
- "media/webrtc/window_icon_util_x11.cc",
"password_manager/native_backend_kwallet_x.cc",
"password_manager/native_backend_kwallet_x.h",
"platform_util_linux.cc",
"shell_integration_linux.cc",
"shell_integration_linux.h",
"speech/tts_linux.cc",
+
+ # TODO(tonikitoo): ThemeServiceAuraX11 does not to dependent X11,
+ # although it is instantiation/inclusion in theme_service_factory.cc
+ # is conditioned by USE_X11.
fwang 2016/10/27 18:19:16 I think you should check wording here. Do you mean
tonikitoo 2016/10/27 18:28:41 Done.
"themes/theme_service_aurax11.cc",
"themes/theme_service_aurax11.h",
"web_applications/web_app_linux.cc",
]
+ if (use_x11) {
+ sources += [
+ "fullscreen_aurax11.cc",
+ "media/webrtc/window_icon_util_x11.cc",
+ ]
+ }
+
# libsecret hard depends on GLib.
if (use_glib) {
sources += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698