Remove USER32 Function Pointer Loading from MessagePumpWin

Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
Committed: https://crrev.com/3502f997323b3dabfa9cee0f581d0deba8b5f689
Cr-Commit-Position: refs/heads/master@{#429943}

[robliao, 2016-10-31 19:37:08]

Description was changed from

==========
Remove USER32 Function Pointer from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

to

==========
Remove USER32 Function Pointers from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

[robliao, 2016-10-31 19:37:23]

Description was changed from

==========
Remove USER32 Function Pointers from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

to

==========
Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

[robliao, 2016-10-31 19:37:30]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:38:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2016-10-31 19:38:46]

robliao@chromium.org changed reviewers:
+ ananta@chromium.org

[robliao, 2016-10-31 19:39:49]

ananta: Please review this CL. Thanks!

Verification: Ran chrome_elf_unittests on a Release non-component build. Passed.

>dumpbin /imports:user32.dll chrome_elf.dll
Microsoft (R) COFF/PE Dumper Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file out\noncomp\chrome_elf.dll

File Type: DLL

  Section contains the following imports:

  Section contains the following delay load imports:

  Summary

        1000 .crthunk
        5000 .data
        1000 .didat
       16000 .rdata
        4000 .reloc
        1000 .rsrc
       4D000 .text
        1000 .tls
        1000 CPADinfo

[commit-bot: I haz the power, 2016-10-31 21:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 21:05:36]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-11-02 17:23:09]

On 2016/10/31 19:39:49, robliao wrote:
> ananta: Please review this CL. Thanks!
> 
> Verification: Ran chrome_elf_unittests on a Release non-component build.
Passed.
> 
> >dumpbin /imports:user32.dll chrome_elf.dll
> Microsoft (R) COFF/PE Dumper Version 14.00.24210.0
> Copyright (C) Microsoft Corporation.  All rights reserved.
> 
> 
> Dump of file out\noncomp\chrome_elf.dll
> 
> File Type: DLL
> 
>   Section contains the following imports:
> 
>   Section contains the following delay load imports:
> 
>   Summary
> 
>         1000 .crthunk
>         5000 .data
>         1000 .didat
>        16000 .rdata
>         4000 .reloc
>         1000 .rsrc
>        4D000 .text
>         1000 .tls
>         1000 CPADinfo

Ping! Thanks.

[robliao, 2016-11-03 22:23:47]

On 2016/11/02 17:23:09, robliao wrote:
> On 2016/10/31 19:39:49, robliao wrote:
> > ananta: Please review this CL. Thanks!
> > 
> > Verification: Ran chrome_elf_unittests on a Release non-component build.
> Passed.
> > 
> > >dumpbin /imports:user32.dll chrome_elf.dll
> > Microsoft (R) COFF/PE Dumper Version 14.00.24210.0
> > Copyright (C) Microsoft Corporation.  All rights reserved.
> > 
> > 
> > Dump of file out\noncomp\chrome_elf.dll
> > 
> > File Type: DLL
> > 
> >   Section contains the following imports:
> > 
> >   Section contains the following delay load imports:
> > 
> >   Summary
> > 
> >         1000 .crthunk
> >         5000 .data
> >         1000 .didat
> >        16000 .rdata
> >         4000 .reloc
> >         1000 .rsrc
> >        4D000 .text
> >         1000 .tls
> >         1000 CPADinfo
> 
> Ping! Thanks.

One of the tests just reported failure for
https://codereview.chromium.org/2472023003/ (test case CL) as expected:
ELFImportsTest.ChromeElfLoadSanityTest (run #1):
[ RUN      ] ELFImportsTest.ChromeElfLoadSanityTest
e:\c\win\src\chrome_elf\elf_imports_unittest.cc(131): error: Failed
Couldn't find
OK ] ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl
 in output
 Note: Google Test filter = ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ELFImportsTest
[ RUN      ] ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl
e:\c\win\src\chrome_elf\elf_imports_unittest.cc(154): error: Value of:
::GetModuleHandleW(L"user32.dll")
  Actual: 00007FFDD05B0000
Expected: nullptr
Which is: NULL
[  FAILED  ] ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl (7 ms)
[----------] 1 test from ELFImportsTest (7 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (7 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl

It appears we should be good to go for this change.

[ananta, 2016-11-03 22:28:01]

lgtm

[robliao, 2016-11-03 22:33:21]

robliao@chromium.org changed reviewers:
+ thestig@chromium.org

[robliao, 2016-11-03 22:33:23]

thestig@chromium.org: Please review this CL. Thanks!

[Lei Zhang, 2016-11-03 22:44:44]

If it's not needed (anymore?), then lgtm!

[robliao, 2016-11-03 22:46:33]

On 2016/11/03 22:44:44, Lei Zhang wrote:
> If it's not needed (anymore?), then lgtm!

For reference, to find the failing test in the dependent patchset, look at this
bot:
https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x...

[robliao, 2016-11-03 22:47:01]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:48:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:59:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 02:59:56]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[robliao, 2016-11-04 16:46:45]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:47:18]

Description was changed from

==========
Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

to

==========
Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

[commit-bot: I haz the power, 2016-11-04 17:47:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 18:17:31]

Description was changed from

==========
Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930
==========

to

==========
Remove USER32 Function Pointer Loading from MessagePumpWin

Even with regular functions, chrome_elf doesn't pull in user32.

BUG=660930

Committed: https://crrev.com/3502f997323b3dabfa9cee0f581d0deba8b5f689
Cr-Commit-Position: refs/heads/master@{#429943}
==========

[commit-bot: I haz the power, 2016-11-04 18:17:32]

Patchset 1 (id:??) landed as
https://crrev.com/3502f997323b3dabfa9cee0f581d0deba8b5f689
Cr-Commit-Position: refs/heads/master@{#429943}