Remove USER32 Function Pointer Loading from MessagePumpWin

base/message_loop/message_pump_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop/message_pump_win.h"
 
 #include <math.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 11 matching lines @@
 namespace {
 
 enum MessageLoopProblems {
   MESSAGE_POST_ERROR,
   COMPLETION_POST_ERROR,
   SET_TIMER_ERROR,
   RECEIVED_WM_QUIT_ERROR,
   MESSAGE_LOOP_PROBLEM_MAX,
 };
 
-// The following define pointers to user32 API's for the API's which are used
-// in this file. These are added to avoid directly depending on user32 from
-// base as there are users of base who don't want this.
-decltype(::TranslateMessage)* g_translate_message = nullptr;
-decltype(::DispatchMessageW)* g_dispatch_message = nullptr;
-decltype(::PeekMessageW)* g_peek_message = nullptr;
-decltype(::PostMessageW)* g_post_message = nullptr;
-decltype(::DefWindowProcW)* g_def_window_proc = nullptr;
-decltype(::PostQuitMessage)* g_post_quit = nullptr;
-decltype(::UnregisterClassW)* g_unregister_class = nullptr;
-decltype(::RegisterClassExW)* g_register_class = nullptr;
-decltype(::CreateWindowExW)* g_create_window_ex = nullptr;
-decltype(::DestroyWindow)* g_destroy_window = nullptr;
-decltype(::CallMsgFilterW)* g_call_msg_filter = nullptr;
-decltype(::GetQueueStatus)* g_get_queue_status = nullptr;
-decltype(::MsgWaitForMultipleObjectsEx)* g_msg_wait_for_multiple_objects_ex =
-    nullptr;
-decltype(::SetTimer)* g_set_timer = nullptr;
-decltype(::KillTimer)* g_kill_timer = nullptr;
-
-#define GET_USER32_API(module, name)         \
-  reinterpret_cast<decltype(name)*>(::GetProcAddress(module, #name))
-
-// Initializes the global pointers to user32 APIs for the API's used in this
-// file.
-void InitUser32APIs() {
-  if (g_translate_message)
-    return;
-
-  HMODULE user32_module = ::GetModuleHandle(L"user32.dll");
-  CHECK(user32_module);
-
-  g_translate_message = GET_USER32_API(user32_module, TranslateMessage);
-  CHECK(g_translate_message);
-
-  g_dispatch_message = GET_USER32_API(user32_module, DispatchMessageW);
-  CHECK(g_dispatch_message);
-
-  g_peek_message = GET_USER32_API(user32_module, PeekMessageW);
-  CHECK(g_peek_message);
-
-  g_post_message = GET_USER32_API(user32_module, PostMessageW);
-  CHECK(g_post_message);
-
-  g_def_window_proc = GET_USER32_API(user32_module, DefWindowProcW);
-  CHECK(g_def_window_proc);
-
-  g_post_quit = GET_USER32_API(user32_module, PostQuitMessage);
-  CHECK(g_post_quit);
-
-  g_unregister_class = GET_USER32_API(user32_module, UnregisterClassW);
-  CHECK(g_unregister_class);
-
-  g_register_class = GET_USER32_API(user32_module, RegisterClassExW);
-  CHECK(g_register_class);
-
-  g_create_window_ex = GET_USER32_API(user32_module, CreateWindowExW);
-  CHECK(g_create_window_ex);
-
-  g_destroy_window = GET_USER32_API(user32_module, DestroyWindow);
-  CHECK(g_destroy_window);
-
-  g_call_msg_filter = GET_USER32_API(user32_module, CallMsgFilterW);
-  CHECK(g_call_msg_filter);
-
-  g_get_queue_status = GET_USER32_API(user32_module, GetQueueStatus);
-  CHECK(g_get_queue_status);
-
-  g_msg_wait_for_multiple_objects_ex =
-      GET_USER32_API(user32_module, MsgWaitForMultipleObjectsEx);
-  CHECK(g_msg_wait_for_multiple_objects_ex);
-
-  g_set_timer = GET_USER32_API(user32_module, SetTimer);
-  CHECK(g_set_timer);
-
-  g_kill_timer = GET_USER32_API(user32_module, KillTimer);
-  CHECK(g_kill_timer);
-}
-
 }  // namespace
 
 static const wchar_t kWndClassFormat[] = L"Chrome_MessagePumpWindow_%p";
 
 // Message sent to get an additional time slice for pumping (processing) another
 // task (a series of such messages creates a continuous task pump).
 static const int kMsgHaveWork = WM_USER + 1;
 
 // The application-defined code passed to the hook procedure.
 static const int kMessageFilterCode = 0x5001;
@@ skipping 47 matching lines @@
   return timeout < 0 ? 0 :
       (timeout > std::numeric_limits<int>::max() ?
        std::numeric_limits<int>::max() : static_cast<int>(timeout));
 }
 
 //-----------------------------------------------------------------------------
 // MessagePumpForUI public:
 
 MessagePumpForUI::MessagePumpForUI()
     : atom_(0) {
-  InitUser32APIs();
   InitMessageWnd();
 }
 
 MessagePumpForUI::~MessagePumpForUI() {
-  g_destroy_window(message_hwnd_);
-  g_unregister_class(MAKEINTATOM(atom_), CURRENT_MODULE());
+  DestroyWindow(message_hwnd_);
+  UnregisterClass(MAKEINTATOM(atom_), CURRENT_MODULE());
 }
 
 void MessagePumpForUI::ScheduleWork() {
   if (InterlockedExchange(&work_state_, HAVE_WORK) != READY)
     return;  // Someone else continued the pumping.
 
   // Make sure the MessagePump does some work for us.
-  BOOL ret = g_post_message(message_hwnd_, kMsgHaveWork,
-                            reinterpret_cast<WPARAM>(this), 0);
+  BOOL ret = PostMessage(message_hwnd_, kMsgHaveWork,
+                         reinterpret_cast<WPARAM>(this), 0);
   if (ret)
     return;  // There was room in the Window Message queue.
 
   // We have failed to insert a have-work message, so there is a chance that we
   // will starve tasks/timers while sitting in a nested message loop.  Nested
   // loops only look at Windows Message queues, and don't look at *our* task
   // queues, etc., so we might not get a time slice in such. :-(
   // We could abort here, but the fear is that this failure mode is plausibly
   // common (queue is full, of about 2000 messages), so we'll do a near-graceful
   // recovery.  Nested loops are pretty transient (we think), so this will
@@ skipping 19 matching lines @@
 LRESULT CALLBACK MessagePumpForUI::WndProcThunk(
     HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam) {
   switch (message) {
     case kMsgHaveWork:
       reinterpret_cast<MessagePumpForUI*>(wparam)->HandleWorkMessage();
       break;
     case WM_TIMER:
       reinterpret_cast<MessagePumpForUI*>(wparam)->HandleTimerMessage();
       break;
   }
-  return g_def_window_proc(hwnd, message, wparam, lparam);
+  return DefWindowProc(hwnd, message, wparam, lparam);
 }
 
 void MessagePumpForUI::DoRunLoop() {
   // IF this was just a simple PeekMessage() loop (servicing all possible work
   // queues), then Windows would try to achieve the following order according
   // to MSDN documentation about PeekMessage with no filter):
   //    * Sent messages
   //    * Posted messages
   //    * Sent messages (again)
   //    * WM_PAINT messages
@@ skipping 20 matching lines @@
     if (state_->should_quit)
       break;
 
     more_work_is_plausible |=
         state_->delegate->DoDelayedWork(&delayed_work_time_);
     // If we did not process any delayed work, then we can assume that our
     // existing WM_TIMER if any will fire when delayed work should run.  We
     // don't want to disturb that timer if it is already in flight.  However,
     // if we did do all remaining delayed work, then lets kill the WM_TIMER.
     if (more_work_is_plausible && delayed_work_time_.is_null())
-      g_kill_timer(message_hwnd_, reinterpret_cast<UINT_PTR>(this));
+      KillTimer(message_hwnd_, reinterpret_cast<UINT_PTR>(this));
     if (state_->should_quit)
       break;
 
     if (more_work_is_plausible)
       continue;
 
     more_work_is_plausible = state_->delegate->DoIdleWork();
     if (state_->should_quit)
       break;
 
     if (more_work_is_plausible)
       continue;
 
     WaitForWork();  // Wait (sleep) until we have work to do again.
   }
 }
 
 void MessagePumpForUI::InitMessageWnd() {
   // Generate a unique window class name.
   string16 class_name = StringPrintf(kWndClassFormat, this);
 
   HINSTANCE instance = CURRENT_MODULE();
   WNDCLASSEX wc = {0};
   wc.cbSize = sizeof(wc);
   wc.lpfnWndProc = base::win::WrappedWindowProc<WndProcThunk>;
   wc.hInstance = instance;
   wc.lpszClassName = class_name.c_str();
-  atom_ = g_register_class(&wc);
+  atom_ = RegisterClassEx(&wc);
   DCHECK(atom_);
 
-  message_hwnd_ = g_create_window_ex(0, MAKEINTATOM(atom_), 0, 0, 0, 0, 0, 0,
-                                     HWND_MESSAGE, 0, instance, 0);
+  message_hwnd_ = CreateWindowEx(0, MAKEINTATOM(atom_), 0, 0, 0, 0, 0, 0,
+                                 HWND_MESSAGE, 0, instance, 0);
   DCHECK(message_hwnd_);
 }
 
 void MessagePumpForUI::WaitForWork() {
   // Wait until a message is available, up to the time needed by the timer
   // manager to fire the next set of timers.
   int delay;
   DWORD wait_flags = MWMO_INPUTAVAILABLE;
 
   while ((delay = GetCurrentDelay()) != 0) {
     if (delay < 0)  // Negative value means no timers waiting.
       delay = INFINITE;
 
-    DWORD result = g_msg_wait_for_multiple_objects_ex(0, nullptr, delay,
-                                                      QS_ALLINPUT, wait_flags);
+    DWORD result = MsgWaitForMultipleObjectsEx(0, nullptr, delay, QS_ALLINPUT,
+                                               wait_flags);
 
     if (WAIT_OBJECT_0 == result) {
       // A WM_* message is available.
       // If a parent child relationship exists between windows across threads
       // then their thread inputs are implicitly attached.
       // This causes the MsgWaitForMultipleObjectsEx API to return indicating
       // that messages are ready for processing (Specifically, mouse messages
       // intended for the child window may appear if the child window has
       // capture).
       // The subsequent PeekMessages call may fail to return any messages thus
       // causing us to enter a tight loop at times.
       // The code below is a workaround to give the child window
       // some time to process its input messages by looping back to
       // MsgWaitForMultipleObjectsEx above when there are no messages for the
       // current thread.
       MSG msg = {0};
       bool has_pending_sent_message =
-          (HIWORD(g_get_queue_status(QS_SENDMESSAGE)) & QS_SENDMESSAGE) != 0;
+          (HIWORD(GetQueueStatus(QS_SENDMESSAGE)) & QS_SENDMESSAGE) != 0;
       if (has_pending_sent_message ||
-          g_peek_message(&msg, nullptr, 0, 0, PM_NOREMOVE)) {
+          PeekMessage(&msg, nullptr, 0, 0, PM_NOREMOVE)) {
         return;
       }
 
       // We know there are no more messages for this thread because PeekMessage
       // has returned false. Reset |wait_flags| so that we wait for a *new*
       // message.
       wait_flags = 0;
     }
 
     DCHECK_NE(WAIT_FAILED, result) << GetLastError();
@@ skipping 17 matching lines @@
 
   // Now give the delegate a chance to do some work.  It'll let us know if it
   // needs to do more work.
   if (state_->delegate->DoWork())
     ScheduleWork();
   state_->delegate->DoDelayedWork(&delayed_work_time_);
   RescheduleTimer();
 }
 
 void MessagePumpForUI::HandleTimerMessage() {
-  g_kill_timer(message_hwnd_, reinterpret_cast<UINT_PTR>(this));
+  KillTimer(message_hwnd_, reinterpret_cast<UINT_PTR>(this));
 
   // If we are being called outside of the context of Run, then don't do
   // anything.  This could correspond to a MessageBox call or something of
   // that sort.
   if (!state_)
     return;
 
   state_->delegate->DoDelayedWork(&delayed_work_time_);
   RescheduleTimer();
 }
@@ skipping 24 matching lines @@
   int delay_msec = GetCurrentDelay();
   DCHECK_GE(delay_msec, 0);
   if (delay_msec == 0) {
     ScheduleWork();
   } else {
     if (delay_msec < USER_TIMER_MINIMUM)
       delay_msec = USER_TIMER_MINIMUM;
 
     // Create a WM_TIMER event that will wake us up to check for any pending
     // timers (in case we are running within a nested, external sub-pump).
-    BOOL ret = g_set_timer(message_hwnd_, reinterpret_cast<UINT_PTR>(this),
-                           delay_msec, nullptr);
+    BOOL ret = SetTimer(message_hwnd_, reinterpret_cast<UINT_PTR>(this),
+                        delay_msec, nullptr);
     if (ret)
       return;
     // If we can't set timers, we are in big trouble... but cross our fingers
     // for now.
     // TODO(jar): If we don't see this error, use a CHECK() here instead.
     UMA_HISTOGRAM_ENUMERATION("Chrome.MessageLoopProblem", SET_TIMER_ERROR,
                               MESSAGE_LOOP_PROBLEM_MAX);
   }
 }
 
 bool MessagePumpForUI::ProcessNextWindowsMessage() {
   // If there are sent messages in the queue then PeekMessage internally
   // dispatches the message and returns false. We return true in this
   // case to ensure that the message loop peeks again instead of calling
   // MsgWaitForMultipleObjectsEx again.
   bool sent_messages_in_queue = false;
-  DWORD queue_status = g_get_queue_status(QS_SENDMESSAGE);
+  DWORD queue_status = GetQueueStatus(QS_SENDMESSAGE);
   if (HIWORD(queue_status) & QS_SENDMESSAGE)
     sent_messages_in_queue = true;
 
   MSG msg;
-  if (g_peek_message(&msg, nullptr, 0, 0, PM_REMOVE) != FALSE)
+  if (PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE) != FALSE)
     return ProcessMessageHelper(msg);
 
   return sent_messages_in_queue;
 }
 
 bool MessagePumpForUI::ProcessMessageHelper(const MSG& msg) {
   TRACE_EVENT1("base", "MessagePumpForUI::ProcessMessageHelper",
                "message", msg.message);
   if (WM_QUIT == msg.message) {
     // Receiving WM_QUIT is unusual and unexpected on most message loops.
     UMA_HISTOGRAM_ENUMERATION("Chrome.MessageLoopProblem",
                               RECEIVED_WM_QUIT_ERROR, MESSAGE_LOOP_PROBLEM_MAX);
     // Repost the QUIT message so that it will be retrieved by the primary
     // GetMessage() loop.
     state_->should_quit = true;
-    g_post_quit(static_cast<int>(msg.wParam));
+    PostQuitMessage(static_cast<int>(msg.wParam));
     return false;
   }
 
   // While running our main message pump, we discard kMsgHaveWork messages.
   if (msg.message == kMsgHaveWork && msg.hwnd == message_hwnd_)
     return ProcessPumpReplacementMessage();
 
-  if (g_call_msg_filter(const_cast<MSG*>(&msg), kMessageFilterCode))
+  if (CallMsgFilter(const_cast<MSG*>(&msg), kMessageFilterCode))
     return true;
 
-  g_translate_message(&msg);
-  g_dispatch_message(&msg);
+  TranslateMessage(&msg);
+  DispatchMessage(&msg);
 
   return true;
 }
 
 bool MessagePumpForUI::ProcessPumpReplacementMessage() {
   // When we encounter a kMsgHaveWork message, this method is called to peek and
   // process a replacement message. The goal is to make the kMsgHaveWork as non-
   // intrusive as possible, even though a continuous stream of such messages are
   // posted. This method carefully peeks a message while there is no chance for
   // a kMsgHaveWork to be pending, then resets the |have_work_| flag (allowing a
   // replacement kMsgHaveWork to possibly be posted), and finally dispatches
   // that peeked replacement. Note that the re-post of kMsgHaveWork may be
   // asynchronous to this thread!!
 
   MSG msg;
   const bool have_message =
-      g_peek_message(&msg, nullptr, 0, 0, PM_REMOVE) != FALSE;
+      PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE) != FALSE;
 
   // Expect no message or a message different than kMsgHaveWork.
   DCHECK(!have_message || kMsgHaveWork != msg.message ||
          msg.hwnd != message_hwnd_);
 
   // Since we discarded a kMsgHaveWork message, we must update the flag.
   int old_work_state_ = InterlockedExchange(&work_state_, READY);
   DCHECK_EQ(HAVE_WORK, old_work_state_);
 
   // We don't need a special time slice if we didn't have_message to process.
   if (!have_message)
     return false;
 
   // Guarantee we'll get another time slice in the case where we go into native
   // windows code.   This ScheduleWork() may hurt performance a tiny bit when
   // tasks appear very infrequently, but when the event queue is busy, the
   // kMsgHaveWork events get (percentage wise) rarer and rarer.
   ScheduleWork();
   return ProcessMessageHelper(msg);
 }
 
 //-----------------------------------------------------------------------------
 // MessagePumpForGpu public:
 
 MessagePumpForGpu::MessagePumpForGpu() {
   event_.Set(CreateEvent(nullptr, FALSE, FALSE, nullptr));
-  InitUser32APIs();
 }
 
 MessagePumpForGpu::~MessagePumpForGpu() {}
 
 // static
 void MessagePumpForGpu::InitFactory() {
   bool init_result = MessageLoop::InitMessagePumpForUIFactory(
       &MessagePumpForGpu::CreateMessagePumpForGpu);
   DCHECK(init_result);
 }
@@ skipping 83 matching lines @@
       delay = INFINITE;
 
     // TODO(stanisc): crbug.com/596190: Preserve for crash dump analysis.
     // Remove this when the bug is fixed.
     TimeTicks wait_for_work_timeticks = TimeTicks::Now();
     debug::Alias(&wait_for_work_timeticks);
     debug::Alias(&delay);
 
     HANDLE handle = event_.Get();
     DWORD result =
-        g_msg_wait_for_multiple_objects_ex(1, &handle, delay, QS_ALLINPUT, 0);
+        MsgWaitForMultipleObjectsEx(1, &handle, delay, QS_ALLINPUT, 0);
     DCHECK_NE(WAIT_FAILED, result) << GetLastError();
     if (result != WAIT_TIMEOUT) {
       // Either work or message available.
       return;
     }
   }
 }
 
 bool MessagePumpForGpu::ProcessNextMessage() {
   MSG msg;
-  if (!g_peek_message(&msg, nullptr, 0, 0, PM_REMOVE))
+  if (!PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE))
     return false;
 
   if (msg.message == WM_QUIT) {
     UMA_HISTOGRAM_ENUMERATION("Chrome.MessageLoopProblem",
                               RECEIVED_WM_QUIT_ERROR, MESSAGE_LOOP_PROBLEM_MAX);
     // WM_QUIT messages shouldn't be received by any threads in the GPU
     // process. If they are, just ignore them instead of causing threads to
     // exit prematurely.
     return true;
   }
 
-  if (!g_call_msg_filter(const_cast<MSG*>(&msg), kMessageFilterCode)) {
-    g_translate_message(&msg);
-    g_dispatch_message(&msg);
+  if (!CallMsgFilter(const_cast<MSG*>(&msg), kMessageFilterCode)) {
+    TranslateMessage(&msg);
+    DispatchMessage(&msg);
   }
 
   return true;
 }
 
 //-----------------------------------------------------------------------------
 // MessagePumpForIO public:
 
 MessagePumpForIO::IOContext::IOContext() {
   memset(&overlapped, 0, sizeof(overlapped));
@@ skipping 164 matching lines @@
     if (!filter || it->handler == filter) {
       *item = *it;
       completed_io_.erase(it);
       return true;
     }
   }
   return false;
 }
 
 }  // namespace base