Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: pnacl/build.sh

Issue 245733002: Added arguments to NaCl scons to allow custom toolchain directories. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Use abspath of environment instead of cwd since cwd can change per test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/buildbot_pnacl_toolchain_tests.sh ('k') | site_scons/site_tools/naclsdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pnacl/build.sh
diff --git a/pnacl/build.sh b/pnacl/build.sh
index 5b6fb8020f7606d9f1ed45269bb15a110178024b..adb852b77bf0c680083ff56bbf4dd0dae8b4ef67 100755
--- a/pnacl/build.sh
+++ b/pnacl/build.sh
@@ -2553,15 +2553,12 @@ sdk-headers() {
StepBanner "SDK" "Install headers"
spushd "${NACL_ROOT}"
- # TODO(pnacl-team): remove this pnaclsdk_mode once we have a better story
- # about host binary type (x86-32 vs x86-64). SCons only knows how to use
- # x86-32 host binaries right now, so we need pnaclsdk_mode to override that.
RunWithLog "sdk.headers" \
./scons \
"${SCONS_ARGS[@]}" \
${extra_flags} \
platform=${neutral_platform} \
- pnaclsdk_mode="custom:${INSTALL_ROOT}" \
+ pnacl_newlib_dir="${INSTALL_ROOT}" \
install_headers \
includedir="$(PosixToSysPath "${SDK_INSTALL_INCLUDE}")"
spopd
@@ -2576,13 +2573,12 @@ sdk-libs() {
local neutral_platform="x86-32"
spushd "${NACL_ROOT}"
- # See above TODO about pnaclsdk_mode.
RunWithLog "sdk.libs.bitcode" \
./scons \
"${SCONS_ARGS[@]}" \
${extra_flags} \
platform=${neutral_platform} \
- pnaclsdk_mode="custom:${INSTALL_ROOT}" \
+ pnacl_newlib_dir="${INSTALL_ROOT}" \
install_lib \
libdir="$(PosixToSysPath "${SDK_INSTALL_LIB}")"
spopd
@@ -2596,13 +2592,12 @@ sdk-private-libs() {
spushd "${NACL_ROOT}"
local neutral_platform="x86-32"
- # See above TODO about pnaclsdk_mode.
RunWithLog "sdk.libs_private.bitcode" \
./scons \
-j${PNACL_CONCURRENCY} \
bitcode=1 \
platform=${neutral_platform} \
- pnaclsdk_mode="custom:${INSTALL_ROOT}" \
+ pnacl_newlib_dir="${INSTALL_ROOT}" \
--verbose \
libnacl_sys_private \
libpthread_private \
« no previous file with comments | « buildbot/buildbot_pnacl_toolchain_tests.sh ('k') | site_scons/site_tools/naclsdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698