Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2752)

Unified Diff: buildbot/buildbot_pnacl_toolchain_tests.sh

Issue 245733002: Added arguments to NaCl scons to allow custom toolchain directories. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Use abspath of environment instead of cwd since cwd can change per test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/buildbot_pnacl.sh ('k') | pnacl/build.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/buildbot_pnacl_toolchain_tests.sh
diff --git a/buildbot/buildbot_pnacl_toolchain_tests.sh b/buildbot/buildbot_pnacl_toolchain_tests.sh
index 34cf616282fd2e51fbe87efa96434758231e0556..410691432dafa7e0829e972aa1d821c306af36f2 100755
--- a/buildbot/buildbot_pnacl_toolchain_tests.sh
+++ b/buildbot/buildbot_pnacl_toolchain_tests.sh
@@ -57,7 +57,7 @@ export PNACL_TOOLCHAIN_DIR=${TOOLCHAIN_BASE_DIR}/pnacl_newlib
export PNACL_TOOLCHAIN_LABEL=pnacl_linux_x86
# This picks the TC which we just built, even if scons doesn't know
# how to find a 64-bit host toolchain.
-readonly SCONS_PICK_TC="pnaclsdk_mode=custom:toolchain/${PNACL_TOOLCHAIN_DIR}"
+readonly SCONS_PICK_TC="pnacl_newlib_dir=toolchain/${PNACL_TOOLCHAIN_DIR}"
# download-old-tc -
# Download the archived frontend toolchain, if we haven't already
@@ -226,8 +226,8 @@ archived-frontend-test() {
mv toolchain/${PNACL_TOOLCHAIN_DIR} \
toolchain/${TOOLCHAIN_BASE_DIR}/current_tc/${PNACL_TOOLCHAIN_LABEL}
- # Link the old frontend into place. If we just use pnaclsdk_mode to select a
- # different toolchain, SCons will attempt to rebuild the IRT.
+ # Link the old frontend into place. If we select a different toolchain,
+ # SCons will attempt to rebuild the IRT.
ln -s archived_tc/${PNACL_TOOLCHAIN_LABEL} toolchain/${PNACL_TOOLCHAIN_DIR}
# Build the pexes with the old frontend.
« no previous file with comments | « buildbot/buildbot_pnacl.sh ('k') | pnacl/build.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698