Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2457233002: [Android] Call onDismissNoAction() after dismissSnackbar() is called (Closed)

Created:
4 years, 1 month ago by Ian Wen
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Android] Call onDismissNoAction() after dismissSnackbar() is called Previously if a client calls SnackbarManager#dismissSnackbar(), onDismissNoAction() will not be called. This CL changes this behavior to make the API more clear. BUG=652477 Review-Url: https://codereview.chromium.org/2454423002 Cr-Commit-Position: refs/heads/master@{#428451} (cherry picked from commit 33ab9183a2b9ec7fe8e74e48edea2acbbece3e35) Committed: https://chromium.googlesource.com/chromium/src/+/ad2b109c9aaf586294eb4113f64b3e9f603dfc3b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java View 3 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ian Wen
4 years, 1 month ago (2016-10-28 22:50:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ad2b109c9aaf586294eb4113f64b3e9f603dfc3b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698