Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2454423002: [Android] Call onDismissNoAction() after dismissSnackbar() is called (Closed)

Created:
4 years, 1 month ago by Ian Wen
Modified:
4 years, 1 month ago
Reviewers:
Theresa, gone
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Call onDismissNoAction() after dismissSnackbar() is called Previously if a client calls SnackbarManager#dismissSnackbar(), onDismissNoAction() will not be called. This CL changes this behavior to make the API more clear. BUG=652477 Committed: https://crrev.com/33ab9183a2b9ec7fe8e74e48edea2acbbece3e35 Cr-Commit-Position: refs/heads/master@{#428451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarCollection.java View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/snackbar/SnackbarTest.java View 3 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
twellington@ for review. dfalcantara@ for stamp. :) Thank you both!
4 years, 1 month ago (2016-10-28 17:59:30 UTC) #2
gone
lgtm
4 years, 1 month ago (2016-10-28 18:17:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454423002/1
4 years, 1 month ago (2016-10-28 18:17:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 19:06:53 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:24:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33ab9183a2b9ec7fe8e74e48edea2acbbece3e35
Cr-Commit-Position: refs/heads/master@{#428451}

Powered by Google App Engine
This is Rietveld 408576698