Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2457153003: Remove crypto/curve25519.h in favor of BoringSSL's. (Closed)

Created:
4 years, 1 month ago by davidben
Modified:
3 years, 10 months ago
Reviewers:
estark, mattm
CC:
chromium-reviews, blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, Ryan Hamilton
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove crypto/curve25519.h in favor of BoringSSL's. They're the exact same functions, only with BoringSSL/C-style argument order rather than Chromium/C++-style. (Outputs first rather than last.) The //crypto version is just a wrapper. BUG=none Review-Url: https://codereview.chromium.org/2457153003 Cr-Commit-Position: refs/heads/master@{#447090} Committed: https://chromium.googlesource.com/chromium/src/+/d27673a0478336f3e25d8a26066a03701557dfd1

Patch Set 1 #

Patch Set 2 : Remove crypto/curve25519.h in favor of BoringSSL's. #

Patch Set 3 : \ #

Total comments: 7

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -156 lines) Patch
M chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/certificate_reporting/DEPS View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M components/certificate_reporting/error_reporter.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M components/certificate_reporting/error_reporter_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M crypto/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D crypto/curve25519.h View 1 chunk +0 lines, -56 lines 0 comments Download
D crypto/curve25519.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D crypto/curve25519_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 35 (23 generated)
davidben
estark for components/certificate_reporting rch for net/quic
4 years, 1 month ago (2016-10-31 17:42:58 UTC) #15
estark
components/certificate_reporting lgtm
4 years, 1 month ago (2016-10-31 17:45:55 UTC) #16
Ryan Hamilton
https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc File net/quic/core/crypto/curve25519_key_exchange.cc (right): https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc#newcode22 net/quic/core/crypto/curve25519_key_exchange.cc:22: if (private_key.size() != 32) { This file is key ...
4 years, 1 month ago (2016-10-31 18:31:11 UTC) #17
davidben
https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc File net/quic/core/crypto/curve25519_key_exchange.cc (right): https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc#newcode22 net/quic/core/crypto/curve25519_key_exchange.cc:22: if (private_key.size() != 32) { On 2016/10/31 18:31:11, Ryan ...
4 years, 1 month ago (2016-10-31 18:36:19 UTC) #18
Ryan Hamilton
https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc File net/quic/core/crypto/curve25519_key_exchange.cc (right): https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc#newcode22 net/quic/core/crypto/curve25519_key_exchange.cc:22: if (private_key.size() != 32) { On 2016/10/31 18:36:19, davidben ...
4 years, 1 month ago (2016-10-31 18:46:08 UTC) #19
davidben
https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc File net/quic/core/crypto/curve25519_key_exchange.cc (right): https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc#newcode27 net/quic/core/crypto/curve25519_key_exchange.cc:27: memcpy(ka->private_key_, private_key.data(), 32); On 2016/10/31 18:46:07, Ryan Hamilton wrote: ...
4 years, 1 month ago (2016-10-31 18:49:56 UTC) #20
Ryan Hamilton
On 2016/10/31 18:49:56, davidben wrote: > https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc > File net/quic/core/crypto/curve25519_key_exchange.cc (right): > > https://codereview.chromium.org/2457153003/diff/40001/net/quic/core/crypto/curve25519_key_exchange.cc#newcode27 > ...
3 years, 10 months ago (2017-01-30 15:07:04 UTC) #21
davidben
On 2017/01/30 15:07:04, Ryan Hamilton wrote: > On 2016/10/31 18:49:56, davidben wrote: > > > ...
3 years, 10 months ago (2017-01-30 19:01:41 UTC) #22
davidben
+mattm for chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc rch to CC since the QUIC change happened elsewhere already. :-)
3 years, 10 months ago (2017-01-30 22:11:26 UTC) #28
mattm
chrome/browser/safe_browsing/certificate_reporting_service_test_utils.cc lgtm
3 years, 10 months ago (2017-01-30 22:19:35 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457153003/60001
3 years, 10 months ago (2017-01-30 22:22:00 UTC) #32
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 22:27:32 UTC) #35
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d27673a0478336f3e25d8a26066a...

Powered by Google App Engine
This is Rietveld 408576698