Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: appengine/findit/crash/test/crash_pipeline_test.py

Issue 2457153002: replacing the NullCulprit class by None (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/findit.py ('k') | appengine/findit/crash/test/findit_for_chromecrash_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/crash_pipeline_test.py
diff --git a/appengine/findit/crash/test/crash_pipeline_test.py b/appengine/findit/crash/test/crash_pipeline_test.py
index 68f77d8eda59f5951a6665c80f2900c82b6d3e0a..e68099a2c545880b288443b8e10eb5005d58ecc3 100644
--- a/appengine/findit/crash/test/crash_pipeline_test.py
+++ b/appengine/findit/crash/test/crash_pipeline_test.py
@@ -78,6 +78,24 @@ class CrashPipelineTest(CrashTestCase):
analysis = FracasCrashAnalysis.Get(crash_identifiers)
self.assertEqual(analysis_status.ERROR, analysis.status)
+ def testFindCulpritFails(self):
+ crash_identifiers = DummyCrashData()['crash_identifiers']
+ analysis = FracasCrashAnalysis.Create(crash_identifiers)
+ analysis.status = analysis_status.RUNNING
+ analysis.put()
+
+ self.mock(FinditForFracas, 'FindCulprit', lambda *_: None)
+ pipeline = crash_pipeline.CrashAnalysisPipeline(
+ CrashClient.FRACAS,
+ crash_identifiers)
+ pipeline.run()
+
+ analysis = FracasCrashAnalysis.Get(crash_identifiers)
+ self.assertEqual(analysis_status.COMPLETED, analysis.status)
+ self.assertFalse(analysis.result['found'])
+ self.assertFalse(analysis.found_suspects)
+ self.assertFalse(analysis.found_project)
+ self.assertFalse(analysis.found_components)
# TODO: this function is a gross hack. We should figure out what the
# semantic goal really is here, so we can avoid doing such intricate
« no previous file with comments | « appengine/findit/crash/findit.py ('k') | appengine/findit/crash/test/findit_for_chromecrash_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698