Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/crash/findit.py

Issue 2457153002: replacing the NullCulprit class by None (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/culprit.py ('k') | appengine/findit/crash/test/crash_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/findit.py
diff --git a/appengine/findit/crash/findit.py b/appengine/findit/crash/findit.py
index 5c56d39e323374bbc6afecfa83030662db827648..be670f9768c1d3087456ef4ed2e25399da272cc8 100644
--- a/appengine/findit/crash/findit.py
+++ b/appengine/findit/crash/findit.py
@@ -12,7 +12,6 @@ from common import chrome_dependency_fetcher
from common import constants
from common import time_util
from crash.crash_report import CrashReport
-from crash.culprit import Culprit
from model import analysis_status
from model.crash.crash_config import CrashConfig
@@ -278,7 +277,7 @@ class Findit(object):
"""Given a CrashAnalysis ndb.Model, return a Culprit."""
stacktrace = self.ParseStacktrace(model)
if stacktrace is None:
- return Culprit('', [], [], None, None)
+ return None
return self._predator.FindCulprit(CrashReport(
crashed_version = model.crashed_version,
« no previous file with comments | « appengine/findit/crash/culprit.py ('k') | appengine/findit/crash/test/crash_pipeline_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698