Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h

Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h
index eb33d1752b8976f864c11ba9d11e9652d2110844..affa6ed45363a66cb4fc1ab41e734a0fca1b5f8a 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_tree_node.h
@@ -11,13 +11,13 @@
namespace blink {
class NGConstraintSpace;
-struct NGExclusion;
// 3 node R-Tree that represents available space(left, bottom, right) or
// layout opportunity after the parent spatial rectangle is split by the
// exclusion rectangle.
struct CORE_EXPORT NGLayoutOpportunityTreeNode
: public GarbageCollected<NGLayoutOpportunityTreeNode> {
+ public:
// Default constructor.
// Creates a Layout Opportunity tree node that is limited by it's own edge
// from above.
@@ -35,15 +35,15 @@ struct CORE_EXPORT NGLayoutOpportunityTreeNode
Member<NGLayoutOpportunityTreeNode> bottom;
Member<NGLayoutOpportunityTreeNode> right;
- // Exclusion that split apart this layout opportunity.
- Member<const NGExclusion> exclusion;
-
// The top layout opportunity associated with this node.
NGLogicalRect opportunity;
// Edge that limits this layout opportunity from above.
NGEdge exclusion_edge;
+ // Exclusion that splits apart this layout opportunity.
+ const NGLogicalRect* exclusion; // Not owned.
+
// Whether this node is a leaf node.
// The node is a leaf if it doesn't have an exclusion that splits it apart.
bool IsLeafNode() const { return !exclusion; }

Powered by Google App Engine
This is Rietveld 408576698