Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 199fee72ea41e2c4d77e53e584a7bcb198b4330a..d7dc3f1c598d08581a607d990ba298aff8a68a29 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -29,7 +29,7 @@ NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
physical_space_ =
new NGPhysicalConstraintSpace(size.ConvertToPhysical(writing_mode));
for (const auto& exclusion : other.PhysicalSpace()->Exclusions()) {
- physical_space_->AddExclusion(exclusion);
+ physical_space_->AddExclusion(*exclusion.get());
}
}
@@ -82,7 +82,10 @@ NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(
builder.ToConstraintSpace());
}
-void NGConstraintSpace::AddExclusion(const NGExclusion* exclusion) const {
+void NGConstraintSpace::AddExclusion(const NGLogicalRect& exclusion) const {
+ WRITING_MODE_IGNORED(
+ "Exclusions are stored directly in physical constraint"
+ "space.");
ikilpatrick 2016/10/28 23:18:24 previous line?
Gleb Lanbin 2016/10/28 23:54:09 Done.
MutablePhysicalSpace()->AddExclusion(exclusion);
}

Powered by Google App Engine
This is Rietveld 408576698