Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2457013004: Use NGLogicalRect instead of NGExclusion for exclusions. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index 917ebd4f3127f817d41a9926866a54958a78f594..82beb9bdda4c5a08f26778a09da7e3b1bf76b02a 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -6,6 +6,7 @@
#define NGConstraintSpace_h
#include "core/CoreExport.h"
+#include "core/layout/ng/ng_macros.h"
#include "core/layout/ng/ng_physical_constraint_space.h"
#include "core/layout/ng/ng_writing_mode.h"
#include "platform/heap/Handle.h"
@@ -56,6 +57,13 @@ class CORE_EXPORT NGConstraintSpace final
return physical_space_;
}
+ const Vector<std::unique_ptr<const NGLogicalRect>>& Exclusions() const {
+ WRITING_MODE_IGNORED(
+ "Exclusions are stored directly in physical constraint"
+ "space.");
ikilpatrick 2016/10/28 23:18:24 can fit on previous line?
Gleb Lanbin 2016/10/28 23:54:09 Done.
+ return PhysicalSpace()->Exclusions();
+ }
+
NGDirection Direction() const { return static_cast<NGDirection>(direction_); }
NGWritingMode WritingMode() const {
@@ -65,7 +73,7 @@ class CORE_EXPORT NGConstraintSpace final
// Adds the exclusion in the physical constraint space.
// Passing the exclusion ignoring the writing mode is fine here since the
// exclusion is set in physical coordinates.
- void AddExclusion(const NGExclusion* exclusion) const;
+ void AddExclusion(const NGLogicalRect& exclusion) const;
// Size of the container. Used for the following three cases:
// 1) Percentage resolution.

Powered by Google App Engine
This is Rietveld 408576698