Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-captions.html

Issue 2456993003: Improve caption button behavior for video player. (Closed)
Patch Set: Addresss feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-controls-captions.html
diff --git a/third_party/WebKit/LayoutTests/media/video-controls-captions.html b/third_party/WebKit/LayoutTests/media/video-controls-captions.html
index 63302da979c4decf9ea687cc963556dc3f989bd8..608bcbe3cc37904f45331a45320d4c33555ba9f5 100644
--- a/third_party/WebKit/LayoutTests/media/video-controls-captions.html
+++ b/third_party/WebKit/LayoutTests/media/video-controls-captions.html
@@ -6,6 +6,7 @@
<script src="media-controls.js"></script>
<video controls>
<track src="track/captions-webvtt/captions-fast.vtt" kind="captions">
+ <track src="track/captions-webvtt/captions-rtl.vtt" kind="captions">
</video>
<script>
async_test(function(t) {
@@ -15,12 +16,12 @@ async_test(function(t) {
assert_true(isClosedCaptionsButtonVisible(video));
// The captions track should be listed in textTracks, but not yet loaded.
- assert_equals(video.textTracks.length, 1);
+ assert_equals(video.textTracks.length, 2);
assert_equals(video.textTracks[0].mode, "disabled");
assert_equals(textTrackContainerElement(video), null);
- var track = document.querySelector("track");
- track.onload = t.step_func(function() {
+ var tracks = document.querySelectorAll("track");
+ tracks[0].onload = t.step_func(function() {
assert_equals(textTrackDisplayElement(video).innerText, "Lorem");
// Captions should not be visible after Off is clicked.
@@ -28,7 +29,8 @@ async_test(function(t) {
assert_equals(textTrackDisplayElement(video), null);
// Remove DOM node representing the track element.
- track.remove();
+ tracks[1].remove();
+ tracks[0].remove();
assert_false(isClosedCaptionsButtonVisible(video));
addUnloadableHTMLTrackElement();

Powered by Google App Engine
This is Rietveld 408576698