Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html

Issue 2456993003: Improve caption button behavior for video player. (Closed)
Patch Set: Addresss feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html
diff --git a/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html b/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html
index 383bc912e7cf1928fc84316774b429e56f407222..49906b1f327136c4c2bafde721521a88fbbbbfed 100644
--- a/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html
+++ b/third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html
@@ -2,50 +2,42 @@
<title>Tests that tracks can be turned on and off through the track selection menu.</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
-<script src="media-file.js"></script>
<script src="media-controls.js"></script>
+<script src="media-file.js"></script>
<video controls></video>
<script>
async_test(function(t) {
- var text = ["First", "Second", "Third"];
+ var captions = ["First", "Second", "Third"];
var video = document.querySelector("video");
video.oncanplaythrough = t.step_func_done(function() {
- var track = video.addTextTrack("captions");
+ var track1 = video.addTextTrack("captions");
+ var track2 = video.addTextTrack("captions");
- for (var i = 0; i < text.length; i++) {
- var cue = new VTTCue(0, 120, text[i]);
- track.addCue(cue);
+ for (var i = 0; i < captions.length; i++) {
+ track1.addCue(new VTTCue(0, 120, captions[i]));
+ track2.addCue(new VTTCue(0, 120, captions[i]));
}
assert_true(isClosedCaptionsButtonVisible(video));
// The captions track should be listed in textTracks, but not yet loaded.
- assert_equals(video.textTracks.length, 1);
+ assert_equals(video.textTracks.length, 2);
assert_equals(video.textTracks[0].mode, "hidden");
- checkCaptionsHidden();
+ checkCaptionsHidden(video);
// Captions track should become visible after the track is selected.
clickTextTrackAtIndex(video, 0);
- checkCaptionsVisible();
+ checkCaptionsVisible(video, captions);
// Captions should not be visible after they're turned off through the menu.
turnClosedCaptionsOff(video);
- checkCaptionsHidden();
+ checkCaptionsHidden(video);
// Captions track should become visible after the track is selected again.
clickTextTrackAtIndex(video, 0);
- checkCaptionsVisible();
+ checkCaptionsVisible(video, captions);
});
- function checkCaptionsVisible() {
- for (var i = 0; i < text.length; i++)
- assert_equals(textTrackCueElementByIndex(video, i).innerText, text[i]);
- }
-
- function checkCaptionsHidden() {
- assert_equals(textTrackDisplayElement(video), null);
- }
-
video.src = findMediaFile("video", "content/counting");
});
</script>

Powered by Google App Engine
This is Rietveld 408576698