Issue 2456783003: Let CastMediaBlocker observe MediaSession instead of WebContents [FOR TRY]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2456783003: Let CastMediaBlocker observe MediaSession instead of WebContents [FOR TRY] (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews, creis+watch_chromium.org, lcwu+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Let CastMediaBlocker observe MediaSession instead of WebContents [FOR TRY] BUG=658678

Patch Set 1 #

Patch Set 2 : fix build #

Patch Set 3 : fixed Linux build #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+773 lines, -3057 lines)			Patch
M	chromecast/browser/cast_media_blocker.h	View		2 chunks	+4 lines, -19 lines	0 comments	Download
M	chromecast/browser/cast_media_blocker.cc	View		7 chunks	+12 lines, -22 lines	0 comments	Download
M	chromecast/browser/test/cast_media_blocker_test.cc	View		12 chunks	+63 lines, -53 lines	0 comments	Download
M	chromecast/browser/test/chromecast_browser_test_helper_default.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/browser/BUILD.gn	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/media/session/audio_focus_delegate.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/browser/media/session/audio_focus_delegate_android.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/media/session/audio_focus_delegate_android.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/media/session/audio_focus_delegate_android_browsertest.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/media/session/audio_focus_delegate_default.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/media/session/audio_focus_delegate_default_browsertest.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	content/browser/media/session/audio_focus_manager.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/media/session/audio_focus_manager.cc	View		7 chunks	+13 lines, -10 lines	0 comments	Download
M	content/browser/media/session/audio_focus_manager_unittest.cc	View		22 chunks	+60 lines, -37 lines	0 comments	Download
D	content/browser/media/session/media_session.h	View		1 chunk	+0 lines, -245 lines	0 comments	Download
D	content/browser/media/session/media_session.cc	View		1 chunk	+0 lines, -447 lines	0 comments	Download
D	content/browser/media/session/media_session_browsertest.cc	View		1 chunk	+0 lines, -1356 lines	0 comments	Download
M	content/browser/media/session/media_session_controller.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/media/session/media_session_controller.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/browser/media/session/media_session_controller_unittest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/media/session/media_session_controllers_manager.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	content/browser/media/session/media_session_impl.h	View		9 chunks	+47 lines, -49 lines	0 comments	Download
A +	content/browser/media/session/media_session_impl.cc	View		15 chunks	+77 lines, -54 lines	0 comments	Download
A +	content/browser/media/session/media_session_impl_browsertest.cc	View		63 chunks	+237 lines, -349 lines	0 comments	Download
A +	content/browser/media/session/media_session_impl_visibility_browsertest.cc	View		8 chunks	+55 lines, -58 lines	0 comments	Download
M	content/browser/media/session/media_session_service_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	content/browser/media/session/media_session_visibility_browsertest.cc	View		1 chunk	+0 lines, -310 lines	0 comments	Download
M	content/browser/media/session/pepper_playback_observer.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	content/public/browser/BUILD.gn	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	content/public/browser/media_session.h	View		1 chunk	+55 lines, -0 lines	0 comments	Download
A	content/public/browser/media_session_observer.h	View		1 chunk	+58 lines, -0 lines	0 comments	Download
A	content/public/browser/media_session_observer.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	content/test/BUILD.gn	View		1 chunk	+2 lines, -2 lines	0 comments	Download