Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2456673003: Butler: export Coordinator host in environment. (Closed)

Created:
4 years, 1 month ago by dnj
Modified:
4 years, 1 month ago
Reviewers:
Vadim Sh., nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Butler: export Coordinator host in environment. Export the configured Coordinator host as an environment variable, if present. Update the bootstrap client to pull this value out of the environment as well. BUG=chromium:659291 TEST=local - Ran Butler locally w/ debug, observed host in environment. Committed: https://github.com/luci/luci-go/commit/ca2642967ad3c8b5b16068dc03e126c81231a341

Patch Set 1 #

Total comments: 1

Patch Set 2 : Relieve suspense. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -20 lines) Patch
M logdog/client/butler/bootstrap/env.go View 2 chunks +5 lines, -0 lines 0 comments Download
M logdog/client/butlerlib/bootstrap/bootstrap.go View 1 2 chunks +15 lines, -3 lines 0 comments Download
M logdog/client/butlerlib/bootstrap/bootstrap_test.go View 1 chunk +7 lines, -5 lines 0 comments Download
M logdog/client/butlerlib/bootstrap/environment.go View 1 chunk +4 lines, -0 lines 0 comments Download
M logdog/client/cmd/logdog_butler/main.go View 1 chunk +3 lines, -8 lines 0 comments Download
M logdog/client/cmd/logdog_butler/output_logdog.go View 2 chunks +6 lines, -1 line 0 comments Download
M logdog/client/cmd/logdog_butler/subcommand_run.go View 2 chunks +13 lines, -1 line 0 comments Download
M logdog/client/cmd/logdog_butler/subcommand_serve.go View 1 chunk +6 lines, -1 line 0 comments Download
M logdog/client/cmd/logdog_butler/subcommand_stream.go View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dnj
PTAL
4 years, 1 month ago (2016-10-27 04:41:38 UTC) #2
Vadim Sh.
lgtm https://codereview.chromium.org/2456673003/diff/1/logdog/client/butlerlib/bootstrap/bootstrap.go File logdog/client/butlerlib/bootstrap/bootstrap.go (right): https://codereview.chromium.org/2456673003/diff/1/logdog/client/butlerlib/bootstrap/bootstrap.go#newcode21 logdog/client/butlerlib/bootstrap/bootstrap.go:21: // Bootstrap contains information about the about the ...
4 years, 1 month ago (2016-10-27 04:48:05 UTC) #3
dnj
On 2016/10/27 04:48:05, Vadim Sh. wrote: > lgtm > > https://codereview.chromium.org/2456673003/diff/1/logdog/client/butlerlib/bootstrap/bootstrap.go > File logdog/client/butlerlib/bootstrap/bootstrap.go (right): ...
4 years, 1 month ago (2016-10-27 06:00:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456673003/20001
4 years, 1 month ago (2016-10-27 06:03:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/321dc6e239e55410)
4 years, 1 month ago (2016-10-27 08:06:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456673003/20001
4 years, 1 month ago (2016-10-27 16:03:47 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:11:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/ca2642967ad3c8b5b16068dc03e126c81231a341

Powered by Google App Engine
This is Rietveld 408576698