logdog/client/cmd/logdog_butler/subcommand_serve.go - Issue 2456673003: Butler: export Coordinator host in environment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/client/cmd/logdog_butler/subcommand_serve.go

Issue 2456673003: Butler: export Coordinator host in environment. (Closed)

Patch Set: Relieve suspense. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: logdog/client/cmd/logdog_butler/subcommand_serve.go

diff --git a/logdog/client/cmd/logdog_butler/subcommand_serve.go b/logdog/client/cmd/logdog_butler/subcommand_serve.go

index 51b1aacfafe70ab7e78a6fa7ca24a49eb8daadcd..5b6d06ba059c18db4f8e232695c359a18c2a817f 100644

--- a/logdog/client/cmd/logdog_butler/subcommand_serve.go

+++ b/logdog/client/cmd/logdog_butler/subcommand_serve.go

@@ -49,7 +49,12 @@ func (cmd *serveCommandRun) Run(app subcommands.Application, args []string) int

}

// We think everything will work. Configure our Output instance.

- output, err := a.configOutput()

+ of, err := a.getOutputFactory()

+ if err != nil {

+ log.WithError(err).Errorf(a, "Failed to get output factory instance.")

+ return runtimeErrorReturnCode

+ }

+ output, err := of.configOutput(a)

if err != nil {

log.WithError(err).Errorf(a, "Failed to create output instance.")

return runtimeErrorReturnCode