Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2456663004: endpoints_webapp2: fix parsing params in GET request (Closed)

Created:
4 years, 1 month ago by nodir
Modified:
4 years, 1 month ago
Reviewers:
KevinL, kjlubick, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

endpoints_webapp2: fix parsing params in GET request If a GET handler uses a resource container, the adaptor did not parse fields defined in the message. This was a bug in https://codereview.chromium.org/2370413002. R=maruel@chromium.org, kjlubick@chromium.org BUG=650245 Committed: https://github.com/luci/luci-py/commit/98093011fef28b43e0596777525aae707198eaf4

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M appengine/components/components/endpoints_webapp2.py View 1 chunk +6 lines, -6 lines 0 comments Download
M appengine/components/components/endpoints_webapp2_test.py View 1 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
nodir
PTAL
4 years, 1 month ago (2016-10-27 14:55:26 UTC) #1
kjlubick
lgtm
4 years, 1 month ago (2016-10-27 15:01:25 UTC) #3
KevinL
lgtm
4 years, 1 month ago (2016-10-27 15:01:36 UTC) #4
M-A Ruel
thanks! fixed typos in CL description. lgtm
4 years, 1 month ago (2016-10-27 15:14:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456663004/1
4 years, 1 month ago (2016-10-27 15:22:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/321f90318d6deb10)
4 years, 1 month ago (2016-10-27 15:27:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456663004/20001
4 years, 1 month ago (2016-10-27 17:16:46 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 17:19:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/98093011fef28b43e0596777525aae707198eaf4

Powered by Google App Engine
This is Rietveld 408576698