Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2370413002: endpoints_webapp2: honor GET requests with messages (Closed)

Created:
4 years, 2 months ago by nodir
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

endpoints_webapp2: honor GET requests with messages Add support for GET request handlers that accept a message instead of a resource container. R=maruel@chromium.org BUG=650245 Committed: https://github.com/luci/luci-py/commit/618c81d1957a49e75b6f351bff3f7ac325bf51eb

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -18 lines) Patch
M appengine/components/components/endpoints_webapp2.py View 1 1 chunk +26 lines, -18 lines 0 comments Download
A appengine/components/components/endpoints_webapp2_test.py View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nodir
PTAL
4 years, 2 months ago (2016-09-28 00:19:04 UTC) #1
M-A Ruel
thanks a lot, lgtm
4 years, 2 months ago (2016-09-28 01:04:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2370413002/20001
4 years, 2 months ago (2016-09-28 22:55:34 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 22:58:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/618c81d1957a49e75b6f351bff3f7ac325bf51eb

Powered by Google App Engine
This is Rietveld 408576698