Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2456483003: Fix payments layout test timeout. (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix payments layout test timeout. A payments layout test was timing out due to not being able to find the mojo file that it was mocking. That file has moved from third_party/WebKit to components/payments. Updating the location of the mojo file fixes the timeout. The patch also removes a stale reference to this mojo file from DEPS. BUG=659391 Committed: https://crrev.com/a02160012bad1d6486ddcc17966fa585fd585cbb Cr-Commit-Position: refs/heads/master@{#427998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
please use gerrit instead
alancutter, ptal.
4 years, 1 month ago (2016-10-26 13:44:54 UTC) #4
please use gerrit instead
thestig, ptal chrome/browser/DEPS.
4 years, 1 month ago (2016-10-26 13:45:28 UTC) #6
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-26 16:53:26 UTC) #9
alancutter (OOO until 2018)
lgtm
4 years, 1 month ago (2016-10-27 02:00:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456483003/1
4 years, 1 month ago (2016-10-27 11:46:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 11:51:49 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 11:54:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a02160012bad1d6486ddcc17966fa585fd585cbb
Cr-Commit-Position: refs/heads/master@{#427998}

Powered by Google App Engine
This is Rietveld 408576698