Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2451873003:
Allow duplicate payment method identifiers. (Closed)
|
Created:
4 years, 1 month ago by please use gerrit instead Modified:
4 years, 1 month ago CC:
chromium-reviews, blink-reviews, rouslan+payments_chromium.org, haraken, sebsg+paymentswatch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow duplicate payment method identifiers.
https://github.com/w3c/browser-payment-api/pull/261/files removed
he following text from the spec:
"If a <a>payment method identifier</a> appears more than once in the
<code>methodData</code> or <code>details.modifiers</code> sequences,
then <a>throw</a> a <a><code>TypeError</code></a>."
This makes duplicate payment method identifiers OK to use.
https://w3c.github.io/browser-payment-api/#paymentrequest-constructor
BUG=659332
Committed: https://crrev.com/e5c07135bb48e6e2c50117be7c9bc01e7ce10538
Cr-Commit-Position: refs/heads/master@{#428432}
Patch Set 1 : Rebase #Patch Set 2 : Rebase 2 #Patch Set 3 : Make modifier total optional #
Messages
Total messages: 35 (22 generated)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Allow duplicate payment method identifiers. BUG=659332 ========== to ========== Allow duplicate payment method identifiers. https://github.com/w3c/browser-payment-api/pull/261/files removed he following text from the spec: "If a <a>payment method identifier</a> appears more than once in the <code>methodData</code> or <code>details.modifiers</code> sequences, then <a>throw</a> a <a><code>TypeError</code></a>." This makes duplicate payment method identifiers OK to use. https://w3c.github.io/browser-payment-api/#paymentrequest-constructor BUG=659332 ==========
Patchset #1 (id:1) has been deleted
rouslan@chromium.org changed reviewers: + mathp@chromium.org
mathp, ptal.
lgtm
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by rouslan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rouslan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org Link to the patchset: https://codereview.chromium.org/2451873003/#ps40001 (title: "Rebase 2")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rouslan@chromium.org changed reviewers: + tsepez@chromium.org
tsepez, ptal payment_request.mojom.
RS LGTM
The CQ bit was checked by rouslan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org Link to the patchset: https://codereview.chromium.org/2451873003/#ps60001 (title: "Make modifier total optional")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Allow duplicate payment method identifiers. https://github.com/w3c/browser-payment-api/pull/261/files removed he following text from the spec: "If a <a>payment method identifier</a> appears more than once in the <code>methodData</code> or <code>details.modifiers</code> sequences, then <a>throw</a> a <a><code>TypeError</code></a>." This makes duplicate payment method identifiers OK to use. https://w3c.github.io/browser-payment-api/#paymentrequest-constructor BUG=659332 ========== to ========== Allow duplicate payment method identifiers. https://github.com/w3c/browser-payment-api/pull/261/files removed he following text from the spec: "If a <a>payment method identifier</a> appears more than once in the <code>methodData</code> or <code>details.modifiers</code> sequences, then <a>throw</a> a <a><code>TypeError</code></a>." This makes duplicate payment method identifiers OK to use. https://w3c.github.io/browser-payment-api/#paymentrequest-constructor BUG=659332 Committed: https://crrev.com/e5c07135bb48e6e2c50117be7c9bc01e7ce10538 Cr-Commit-Position: refs/heads/master@{#428432} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e5c07135bb48e6e2c50117be7c9bc01e7ce10538 Cr-Commit-Position: refs/heads/master@{#428432} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
