Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 2456293002: Stop calling Persistent::uninitialize after blink::shutdown is called. (Closed)

Created:
4 years, 1 month ago by haraken
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Stop calling Persistent::uninitialize after blink::shutdown is called. This CL adds a short-term hack to prevent use-after-frees during a shutdown sequence. Currently the following scenario can happen: 1) blink::shutdown() frees the underlying storage for persistent nodes. 2) ~MessageLoop() destructs some Chromium-side objects that hold Persistent. It touches the underlying storage and crashes. In middle term, we should entirely remove the shutdown sequence and get rid of the hack. BUG=653688 Review-Url: https://codereview.chromium.org/2423743003 Cr-Commit-Position: refs/heads/master@{#425620} (cherry picked from commit 10d68110da927986332bd753b17c08db0feac1c8)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
haraken
4 years, 1 month ago (2016-10-28 08:53:19 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
06c328da54fc69ba48cef2c3ce10a442dccf0eb0.

Powered by Google App Engine
This is Rietveld 408576698