Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2423743003: Stop calling Persistent::uninitialize after blink::shutdown is called. (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
Reviewers:
keishi
CC:
chromium-reviews, blink-reviews, haraken, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop calling Persistent::uninitialize after blink::shutdown is called. This CL adds a short-term hack to prevent use-after-frees during a shutdown sequence. Currently the following scenario can happen: 1) blink::shutdown() frees the underlying storage for persistent nodes. 2) ~MessageLoop() destructs some Chromium-side objects that hold Persistent. It touches the underlying storage and crashes. In middle term, we should entirely remove the shutdown sequence and get rid of the hack. BUG=653688 Committed: https://crrev.com/10d68110da927986332bd753b17c08db0feac1c8 Cr-Commit-Position: refs/heads/master@{#425620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
4 years, 2 months ago (2016-10-17 01:35:04 UTC) #2
keishi
LGTM
4 years, 2 months ago (2016-10-17 01:39:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423743003/1
4 years, 2 months ago (2016-10-17 01:40:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 05:24:45 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 05:26:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10d68110da927986332bd753b17c08db0feac1c8
Cr-Commit-Position: refs/heads/master@{#425620}

Powered by Google App Engine
This is Rietveld 408576698