Cleanup upstreamed Android infobar code.

Cleanup upstreamed Android infobar code.

Some simplifications, and a variety of minor style changes to become consistent
with all the rest of the infobar code.

BUG=none
TEST=none
R=miguelg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225282

[Miguel Garcia, 2013-09-25 23:23:48]

lgtm

thanks for the cleanup!

https://codereview.chromium.org/24562006/diff/1/chrome/browser/ui/android/inf...
File chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc
(right):

https://codereview.chromium.org/24562006/diff/1/chrome/browser/ui/android/inf...
chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc:59:
JNIEnv* env = base::android::AttachCurrentThread();
curious on why the namespace shortcut  is not ok for AttachCurrentThread but is
however ok for ConvertJavaStringToUTF8

[Peter Kasting, 2013-09-25 23:26:23]

https://codereview.chromium.org/24562006/diff/1/chrome/browser/ui/android/inf...
File chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc
(right):

https://codereview.chromium.org/24562006/diff/1/chrome/browser/ui/android/inf...
chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc:59:
JNIEnv* env = base::android::AttachCurrentThread();
On 2013/09/25 23:23:48, Miguel Garcia wrote:
> curious on why the namespace shortcut  is not ok for AttachCurrentThread but
is
> however ok for ConvertJavaStringToUTF8

Why does the unqualified ConvertJavaStringToUTF8() call above even compile? 
Shouldn't this require a namespace too?

I suspect, though, that you meant to ask about ConvertUTF8ToJavaString(). 
Basically, the infobar code tries to avoid using declarations unless they save
some lines.  Switching that call to be fully-qualified would end up adding a
couple more lines of verbosity overall.

[Miguel Garcia, 2013-09-25 23:38:09]

lgtm

Yeah I was asking about the latter, perhaps you can qualify the former call as
well while you are at it?

On 2013/09/25 23:26:23, Peter Kasting wrote:
>
https://codereview.chromium.org/24562006/diff/1/chrome/browser/ui/android/inf...
> File chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc
> (right):
> 
>
https://codereview.chromium.org/24562006/diff/1/chrome/browser/ui/android/inf...
> chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc:59:
> JNIEnv* env = base::android::AttachCurrentThread();
> On 2013/09/25 23:23:48, Miguel Garcia wrote:
> > curious on why the namespace shortcut  is not ok for AttachCurrentThread but
> is
> > however ok for ConvertJavaStringToUTF8
> 
> Why does the unqualified ConvertJavaStringToUTF8() call above even compile? 
> Shouldn't this require a namespace too?
> 
> I suspect, though, that you meant to ask about ConvertUTF8ToJavaString(). 
> Basically, the infobar code tries to avoid using declarations unless they save
> some lines.  Switching that call to be fully-qualified would end up adding a
> couple more lines of verbosity overall.

[Peter Kasting, 2013-09-26 00:08:37]

On 2013/09/25 23:38:09, Miguel Garcia wrote:
> Yeah I was asking about the latter, perhaps you can qualify the former call as
> well while you are at it?

Done.  Landing.

[Peter Kasting, 2013-09-26 00:08:57]

Committed patchset #3 manually as r225282 (presubmit successful).