Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2810)

Unified Diff: chrome/browser/ui/android/infobars/infobar_container_android.h

Issue 24562006: Cleanup upstreamed Android infobar code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/infobar_container_android.h
===================================================================
--- chrome/browser/ui/android/infobars/infobar_container_android.h (revision 225273)
+++ chrome/browser/ui/android/infobars/infobar_container_android.h (working copy)
@@ -15,8 +15,6 @@
#include "chrome/browser/infobars/infobar_container.h"
class InfoBarAndroid;
-class InfoBarDelegate;
-class InfoBarService;
namespace content {
class WebContents;
@@ -38,21 +36,22 @@
}
// The prerender is swapping the web contents.
+// TODO(miguelg) Move this out of infobar container.
void OnWebContentsReplaced(content::WebContents* old_web_contents,
content::WebContents* new_web_contents);
private:
virtual ~InfoBarContainerAndroid() OVERRIDE;
- // InfobarContainer
- virtual void PlatformSpecificAddInfoBar(InfoBar* infobar, size_t position)
- OVERRIDE;
+ // InfobarContainer:
+ virtual void PlatformSpecificAddInfoBar(InfoBar* infobar,
+ size_t position) OVERRIDE;
virtual void PlatformSpecificRemoveInfoBar(InfoBar* infobar) OVERRIDE;
virtual void PlatformSpecificReplaceInfoBar(InfoBar* old_infobar,
InfoBar* new_infobar) OVERRIDE;
// Create the Java equivalent of |android_bar| and add it to the java
- // container
+ // container.
void AttachJavaInfoBar(InfoBarAndroid* android_bar);
// We're owned by the java infobar, need to use a weak ref so it can destroy
@@ -63,7 +62,7 @@
DISALLOW_COPY_AND_ASSIGN(InfoBarContainerAndroid);
};
-// Register the InfoBarContainer's native methods through jni
+// Registers the InfoBarContainer's native methods through JNI.
bool RegisterInfoBarContainer(JNIEnv* env);
#endif // CHROME_BROWSER_UI_ANDROID_INFOBARS_INFOBAR_CONTAINER_ANDROID_H_
« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_android.cc ('k') | chrome/browser/ui/android/infobars/infobar_container_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698