Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2456193002: [LayoutNG] Remove last NGConstraintSpace constructor. (Closed)

Created:
4 years, 1 month ago by ikilpatrick
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, Gleb Lanbin
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Remove last NGConstraintSpace constructor. The other patch is: https://codereview.chromium.org/2456973002/ Main usages was in tests and CreateFromLayoutObject. BUG=635619 Committed: https://crrev.com/631ba4493ab55194d0ed2e2482c296f0aeadcb94 Cr-Commit-Position: refs/heads/master@{#428292}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -75 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 14 chunks +45 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 3 chunks +17 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 1 2 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
ikilpatrick
4 years, 1 month ago (2016-10-27 21:48:41 UTC) #3
Gleb Lanbin
https://codereview.chromium.org/2456193002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc (right): https://codereview.chromium.org/2456193002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc#newcode18 third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:18: NGPhysicalSize(LayoutUnit(200), LayoutUnit(100)), true, false, true, can you add comments ...
4 years, 1 month ago (2016-10-27 22:29:55 UTC) #4
ikilpatrick
https://codereview.chromium.org/2456193002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc (right): https://codereview.chromium.org/2456193002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc#newcode18 third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:18: NGPhysicalSize(LayoutUnit(200), LayoutUnit(100)), true, false, true, On 2016/10/27 22:29:54, glebl ...
4 years, 1 month ago (2016-10-27 23:54:52 UTC) #6
Gleb Lanbin
lgtm
4 years, 1 month ago (2016-10-28 04:08:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456193002/20001
4 years, 1 month ago (2016-10-28 04:09:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 05:21:53 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/631ba4493ab55194d0ed2e2482c296f0aeadcb94 Cr-Commit-Position: refs/heads/master@{#428292}
4 years, 1 month ago (2016-10-28 05:24:09 UTC) #15
cbiesinger
4 years, 1 month ago (2016-10-28 19:05:07 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698