Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2456193002: [LayoutNG] Remove last NGConstraintSpace constructor. (Closed)
Patch Set: address comment. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
index a43f46e402149359aa6448e1b123b0f950564d80..11ae713cf9b55e03969806c2e074c8c3d3a27cf8 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
@@ -6,6 +6,7 @@
#include "core/layout/ng/ng_constraint_space.h"
#include "core/layout/ng/ng_layout_opportunity_iterator.h"
+#include "core/layout/ng/ng_physical_constraint_space.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace blink {
@@ -13,15 +14,17 @@ namespace blink {
namespace {
TEST(NGConstraintSpaceTest, WritingMode) {
+ NGPhysicalConstraintSpace* phy_space = new NGPhysicalConstraintSpace(
+ NGPhysicalSize(LayoutUnit(200), LayoutUnit(100)), /* fixed_width */ true,
+ /* fixed_height */ false, /* width_direction_triggers_scrollbar */ true,
+ /* height_direction_triggers_scrollbar */ false, FragmentNone,
+ FragmentColumn, /* is_new_fc */ false);
+
NGConstraintSpace* horz_space =
- new NGConstraintSpace(HorizontalTopBottom, LeftToRight,
- NGLogicalSize(LayoutUnit(200), LayoutUnit(100)));
- horz_space->SetOverflowTriggersScrollbar(true, false);
- horz_space->SetFixedSize(true, false);
- horz_space->SetFragmentationType(FragmentColumn);
-
- NGConstraintSpace* vert_space = new NGConstraintSpace(
- VerticalRightLeft, LeftToRight, horz_space->MutablePhysicalSpace());
+ new NGConstraintSpace(HorizontalTopBottom, LeftToRight, phy_space);
+
+ NGConstraintSpace* vert_space =
+ new NGConstraintSpace(VerticalRightLeft, LeftToRight, phy_space);
EXPECT_EQ(LayoutUnit(200), horz_space->ContainerSize().inline_size);
EXPECT_EQ(LayoutUnit(200), vert_space->ContainerSize().block_size);

Powered by Google App Engine
This is Rietveld 408576698