Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2456163002: Remove stl_util's STLDeleteContainerPointers. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, gavinp+memory_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's STLDeleteContainerPointers. BUG=555865

Patch Set 1 #

Patch Set 2 : star #

Patch Set 3 : stragglers #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : again #

Patch Set 7 : last few #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -46 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -9 lines 0 comments Download
M base/containers/scoped_ptr_hash_map.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M base/memory/scoped_vector.h View 1 4 chunks +11 lines, -5 lines 0 comments Download
M base/stl_util.h View 2 chunks +8 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store_default_unittest.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_discovery_filter.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M media/base/multi_channel_resampler.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/codec/audio_encoder_opus.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/test/test_event_target.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2459763003 Patch 20001

Messages

Total messages: 28 (28 generated)
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-27 21:31:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/1
4 years, 1 month ago (2016-10-27 21:33:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-27 21:50:05 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/95363)
4 years, 1 month ago (2016-10-27 21:50:06 UTC) #4
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 16:06:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/20001
4 years, 1 month ago (2016-10-28 16:06:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 16:22:25 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/96534)
4 years, 1 month ago (2016-10-28 16:22:27 UTC) #8
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 17:38:32 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/40001
4 years, 1 month ago (2016-10-28 17:38:54 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 18:00:57 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/252520)
4 years, 1 month ago (2016-10-28 18:00:58 UTC) #12
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 20:34:58 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/60001
4 years, 1 month ago (2016-10-28 20:35:15 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 20:57:05 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/305158)
4 years, 1 month ago (2016-10-28 20:57:06 UTC) #16
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 21:19:31 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/80001
4 years, 1 month ago (2016-10-28 21:19:51 UTC) #18
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-28 21:27:03 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/100001
4 years, 1 month ago (2016-10-28 21:27:32 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-28 21:48:35 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/305215)
4 years, 1 month ago (2016-10-28 21:48:35 UTC) #22
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-29 20:58:14 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456163002/120001
4 years, 1 month ago (2016-10-29 20:58:22 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-10-29 22:44:19 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/321828)
4 years, 1 month ago (2016-10-29 22:44:20 UTC) #26
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-10-29 22:45:13 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 22:45:19 UTC) #28

Powered by Google App Engine
This is Rietveld 408576698