components/password_manager/core/browser/password_store_default_unittest.cc - Issue 2456163002: Remove stl_util's STLDeleteContainerPointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 2456163002: Remove stl_util's STLDeleteContainerPointers. (Closed)

Patch Set: last few Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/phone_field_unittest.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc

index 10156f0009b826d8009a15a3ec9c29e0af361ed3..f6b43fe1e0088813e7e46a40e90d8b734a8317ea 100644

--- a/components/password_manager/core/browser/password_store_default_unittest.cc

+++ b/components/password_manager/core/browser/password_store_default_unittest.cc

@@ -13,7 +13,6 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

#include "base/run_loop.h"

-#include "base/stl_util.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "base/time/time.h"

@@ -156,10 +155,6 @@ INSTANTIATE_TYPED_TEST_CASE_P(Default,

PasswordStoreOriginTest,

PasswordStoreDefaultTestDelegate);

-ACTION(STLDeleteElements0) {

- base::STLDeleteContainerPointers(arg0.begin(), arg0.end());

TEST(PasswordStoreDefaultTest, NonASCIIData) {

PasswordStoreDefaultTestDelegate delegate;

PasswordStoreDefault* store = delegate.store();