Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2456053008: Revert of Add initial CL for RandomOrder chromium.fyi bot (Closed)

Created:
4 years, 1 month ago by jeffcarp
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, martiniss
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Add initial CL for RandomOrder chromium.fyi bot (patchset #6 id:100001 of https://codereview.chromium.org/2384243005/ ) Reason for revert: Missed adding the new flags to the bottom of the file as well. http://crbug.com/660503 Original issue's description: > Add initial CL for RandomOrder chromium.fyi bot > > This is a set of 2 CLs: > > 1. build CL (this one) - https://codereview.chromium.org/2384243005/ > 2. src CL - https://codereview.chromium.org/2404573002 > > BUG=652357 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/fc1d3b8658c112563b0c3ae7f6e3303d908fcee1 TBR=dpranke@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=652357 TBR=dpranke Committed: https://chromium.googlesource.com/chromium/tools/build/+/968a142609f3d261c230be4ae350e7f181c3d905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -579 lines) Patch
M masters/master.chromium.fyi/master.cfg View 3 chunks +0 lines, -10 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 chunk +0 lines, -8 lines 0 comments Download
M scripts/slave/chromium/layout_test_wrapper.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 2 chunks +0 lines, -23 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___RandomOrder.json View 1 chunk +0 lines, -534 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
jeffcarp
Created Revert of Add initial CL for RandomOrder chromium.fyi bot
4 years, 1 month ago (2016-10-28 20:42:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456053008/1
4 years, 1 month ago (2016-10-28 20:42:04 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-28 20:42:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456053008/1
4 years, 1 month ago (2016-10-28 20:44:26 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-28 20:44:28 UTC) #10
Michael Achenbach
lgtm
4 years, 1 month ago (2016-10-28 20:53:17 UTC) #12
Michael Achenbach
lgtm
4 years, 1 month ago (2016-10-28 20:53:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456053008/1
4 years, 1 month ago (2016-10-28 20:53:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/968a142609f3d261c230be4ae350e7f181c3d905
4 years, 1 month ago (2016-10-28 20:53:49 UTC) #17
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-28 20:57:12 UTC) #18
jeffcarp
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2459983002/ by jeffcarp@chromium.org. ...
4 years, 1 month ago (2016-10-28 20:57:53 UTC) #19
Michael Achenbach
Also kicked off the recipe roller to get this revert in quickly.
4 years, 1 month ago (2016-10-28 20:58:53 UTC) #20
Michael Achenbach
On 2016/10/28 20:58:53, machenbach (slow) wrote: > Also kicked off the recipe roller to get ...
4 years, 1 month ago (2016-10-28 21:00:49 UTC) #21
Michael Achenbach
hmm, recipe roller is still occupied with the last CL: https://codereview.chromium.org/2463503002 Guess this needs to ...
4 years, 1 month ago (2016-10-28 21:02:48 UTC) #22
Michael Achenbach
4 years, 1 month ago (2016-10-28 21:09:32 UTC) #23
Message was sent while issue was closed.
New roll coming here: https://codereview.chromium.org/2461783003

Powered by Google App Engine
This is Rietveld 408576698