Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: tools/origin_trials/validate_subdomain_origin/BUILD.gn

Issue 2456053004: Validate origins when generating subdomain tokens (Closed)
Patch Set: Fix Windows compile error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/origin_trials/validate_subdomain_origin/BUILD.gn
diff --git a/chrome/tools/mac_helpers/BUILD.gn b/tools/origin_trials/validate_subdomain_origin/BUILD.gn
similarity index 57%
copy from chrome/tools/mac_helpers/BUILD.gn
copy to tools/origin_trials/validate_subdomain_origin/BUILD.gn
index 2beb33b6c8a30841f408f778577126be8363d87b..5793b32c1d047b77533970a3702cc9527cb0478b 100644
--- a/chrome/tools/mac_helpers/BUILD.gn
+++ b/tools/origin_trials/validate_subdomain_origin/BUILD.gn
@@ -2,20 +2,19 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-executable("infoplist_strings_tool") {
- configs += [ "//build/config/compiler:wexit_time_destructors" ]
+import("//build/symlink.gni")
agrieve 2016/11/04 18:06:32 Doesn't look like you're using symlink(), so you c
chasej 2016/11/04 19:26:36 Done.
+executable("validate_subdomain_origin") {
agrieve 2016/11/04 18:06:32 Bonus points if you made this work for target_os="
chasej 2016/11/04 19:26:36 I made the change, but I'm wondering if it applies
+ output_name = "validate_subdomain_origin"
sources = [
- "infoplist_strings_util.mm",
+ "validate_subdomain_origin.cc",
]
+ configs += [ "//build/config/compiler:wexit_time_destructors" ]
+
deps = [
"//base",
- "//base:i18n",
- "//chrome:strings",
- "//third_party/icu",
- "//ui/base:ui_data_pack",
+ "//net",
+ "//url",
]
-
- libs = [ "Foundation.framework" ]
}

Powered by Google App Engine
This is Rietveld 408576698