Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: tools/origin_trials/validate_subdomain_origin/BUILD.gn

Issue 2456053004: Validate origins when generating subdomain tokens (Closed)
Patch Set: Fix Windows compile error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 executable("infoplist_strings_tool") { 5 import("//build/symlink.gni")
agrieve 2016/11/04 18:06:32 Doesn't look like you're using symlink(), so you c
chasej 2016/11/04 19:26:36 Done.
6
7 executable("validate_subdomain_origin") {
agrieve 2016/11/04 18:06:32 Bonus points if you made this work for target_os="
chasej 2016/11/04 19:26:36 I made the change, but I'm wondering if it applies
8 output_name = "validate_subdomain_origin"
9 sources = [
10 "validate_subdomain_origin.cc",
11 ]
12
6 configs += [ "//build/config/compiler:wexit_time_destructors" ] 13 configs += [ "//build/config/compiler:wexit_time_destructors" ]
7 14
8 sources = [
9 "infoplist_strings_util.mm",
10 ]
11
12 deps = [ 15 deps = [
13 "//base", 16 "//base",
14 "//base:i18n", 17 "//net",
15 "//chrome:strings", 18 "//url",
16 "//third_party/icu",
17 "//ui/base:ui_data_pack",
18 ] 19 ]
19
20 libs = [ "Foundation.framework" ]
21 } 20 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698