Refactor AcceleratedStaticBitmapImage

third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
index 948b02956d439adbfc501e2932c0246d4d1f8337..64b5ed8a6faf81844befa95054f6f8b1ef1afaaf 100644
--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
@@ -321,6 +321,9 @@ void OffscreenCanvasFrameDispatcherImpl::DidReceiveCompositorFrameAck() {
 void OffscreenCanvasFrameDispatcherImpl::ReclaimResources(
     const cc::ReturnedResourceArray& resources) {
   for (const auto& resource : resources) {
+    RefPtr<StaticBitmapImage> image = m_cachedImages.get(resource.id);
+    if (image)
+      image->deleteTexture(resource.sync_token.GetConstData());

[xidachen, 2016/10/27 20:20:45]

junov@: With this change, the commit() will crash after certain amount of
frames. If I comment out these three lines, then there is no crash.

Is it possible that we happen to delete the textureId that is the same as the
textureId of current CompositorFrame that is being submitted to the browser?

[Justin Novosad, 2016/10/28 18:08:00]

We should not be deleting any textures here. We should only be removing the
reference to the image, which is taken care of below. If it was the last
reference the the destructor of the TextureHolder should take care of the
delete.

[xidachen, 2016/10/28 21:14:15]

In the new PS, I move the DeleteTexture to the destructor of TextureHolder.
There is no crash, but gpu process eats a lot of memory very quickly. Something
is not right.

     m_cachedImages.remove(resource.id);
     m_sharedBitmaps.remove(resource.id);
     m_cachedTextureIds.remove(resource.id);