Refactor AcceleratedStaticBitmapImage

third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/OffscreenCanvasFrameDispatcherImpl.h"
 
 #include "cc/output/compositor_frame.h"
 #include "cc/quads/texture_draw_quad.h"
 #include "gpu/command_buffer/client/gles2_interface.h"
 #include "platform/Histogram.h"
@@ skipping 303 matching lines @@
   m_sink->SubmitCompositorFrame(std::move(frame));
 }
 
 void OffscreenCanvasFrameDispatcherImpl::DidReceiveCompositorFrameAck() {
   // TODO(fsamuel): Implement this.
 }
 
 void OffscreenCanvasFrameDispatcherImpl::ReclaimResources(
     const cc::ReturnedResourceArray& resources) {
   for (const auto& resource : resources) {
+    RefPtr<StaticBitmapImage> image = m_cachedImages.get(resource.id);
+    if (image)
+      image->deleteTexture(resource.sync_token.GetConstData());

[xidachen, 2016/10/27 20:20:45]

junov@: With this change, the commit() will crash after certain amount of
frames. If I comment out these three lines, then there is no crash.

Is it possible that we happen to delete the textureId that is the same as the
textureId of current CompositorFrame that is being submitted to the browser?

[Justin Novosad, 2016/10/28 18:08:00]

We should not be deleting any textures here. We should only be removing the
reference to the image, which is taken care of below. If it was the last
reference the the destructor of the TextureHolder should take care of the
delete.

[xidachen, 2016/10/28 21:14:15]

In the new PS, I move the DeleteTexture to the destructor of TextureHolder.
There is no crash, but gpu process eats a lot of memory very quickly. Something
is not right.

     m_cachedImages.remove(resource.id);
     m_sharedBitmaps.remove(resource.id);
     m_cachedTextureIds.remove(resource.id);
   }
 }
 
 bool OffscreenCanvasFrameDispatcherImpl::verifyImageSize(
     const sk_sp<SkImage>& image) {
   if (image && image->width() == m_width && image->height() == m_height)
     return true;
   return false;
 }
 
 }  // namespace blink