Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2455983004: NOT FOR SUBMISSION: local copy of leon.han's CL (Closed)

Created:
4 years, 1 month ago by blundell
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, kinuko+worker_chromium.org, mlamouri+watch-content_chromium.org, oilpan-reviews, Mads Ager (chromium), jam, shimazu+worker_chromium.org, haraken, feature-media-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, abarth-chromium, kouhei+heap_chromium.org, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR SUBMISSION: local copy of leon.han's CL [TimeZoneMonitor] Decouple renderer side impl from content to blink. In addition to the decoupling work, this CL: * notifies time zone change to all the workerBackingThread, no matter they do OWN their platform thread or not, while the old behavior is that only those workerBackingThread OWNING a platform thread could get the notifications, which is incorrect. * will initialize TimeZoneMonitorClient in blink::initialize() if a message loop has already been created, this is always true for production code, while some unit tests may have not prepared the message loop when calling blink::initialize(), so TimeZoneMonitorClient won't be initialized. BUG=612341 TEST=http://crbug.com/288697#c12: load the page, change the system time zone, and then click "recheck" to ensure that the renderer picks up the new time zone. Don't reload the page, which is likely to give you a new renderer process, use the "recheck" link on the page. patch from issue 2402983002 at patchset 440001 (http://crrev.com/2402983002#ps440001)

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Incorporate new changes #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -59 lines) Patch
M content/browser/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 5 chunks +0 lines, -12 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 chunks +0 lines, -33 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/run_all_unittests.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 3 4 5 6 7 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/ModulesInitializer.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/time_zone_monitor/BUILD.gn View 1 1 chunk +6 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/modules/time_zone_monitor/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/time_zone_monitor/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.h View 1 2 3 4 5 6 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp View 1 2 3 4 5 6 1 chunk +76 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (16 generated)
blundell
The CQ bit was checked by blundell@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-01 23:38:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455983004/80001
4 years, 1 month ago (2016-11-01 23:38:43 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 01:41:02 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/254504)
4 years, 1 month ago (2016-11-02 01:41:02 UTC) #4
blundell
The CQ bit was checked by blundell@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-07 12:27:36 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455983004/100001
4 years, 1 month ago (2016-11-07 12:27:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-07 13:51:11 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/257520)
4 years, 1 month ago (2016-11-07 13:51:14 UTC) #8
blundell
The CQ bit was checked by blundell@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-08 09:54:56 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455983004/120001
4 years, 1 month ago (2016-11-08 09:55:13 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-08 09:58:22 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg/builds/28727) chromium_presubmit on ...
4 years, 1 month ago (2016-11-08 09:58:23 UTC) #12
blundell
The CQ bit was checked by blundell@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-08 10:04:22 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455983004/140001
4 years, 1 month ago (2016-11-08 10:04:42 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-08 14:57:57 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 14:57:58 UTC) #16
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698