Issue 2455973005: Copy float list of ruby base when merging it with a sibling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2455973005: Copy float list of ruby base when merging it with a sibling (Closed)

Created:
4 years, 1 month ago by rhogan

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Copy float list of ruby base when merging it with a sibling When merging two ruby bases ensure that the new base has a complete float list. A 2nd go at https://crrev.com/6f208d569f6bd2488f2f2f6f9004e54417f78782 BUG=619380, 624028, 644605, 644803 Review-Url: https://codereview.chromium.org/2329863002 Cr-Commit-Position: refs/heads/master@{#424864} (cherry picked from commit 3453e2368a018544e7143e60afbc7a1454e848ed) Committed: https://chromium.googlesource.com/chromium/src/+/615822c475c7373b23f2f75f6939d22a1b1138f0

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -36 lines)			Patch
M	third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash.html	View	1 chunk	+16 lines, -17 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/FloatingObjects.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/FloatingObjects.cpp	View	3 chunks	+5 lines, -15 lines	0 comments	Download
M	third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

rhogan

4 years, 1 month ago (2016-10-28 18:23:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
615822c475c7373b23f2f75f6939d22a1b1138f0.