Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2455853002: Revert of Content in disabled input field should not be selectable. (Closed)

Created:
4 years, 1 month ago by yoichio
Modified:
4 years, 1 month ago
Reviewers:
tkent, ramya.v
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Content in disabled input field should not be selectable. (patchset #4 id:80001 of https://codereview.chromium.org/2145323002/ ) Reason for revert: It caused regression: https://bugs.chromium.org/p/chromium/issues/detail?id=656736 Original issue's description: > Content in disabled input field should not be selectable. > > Spec: https://html.spec.whatwg.org/multipage/forms.html#the-readonly-attribute:attr-input-readonly > > BUG=626581 > > Committed: https://crrev.com/21d670d3e740b26dcdf63631d163c45a57d9531c > Cr-Commit-Position: refs/heads/master@{#405717} TBR=tkent@chromium.org,ramya.v@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=626581 Committed: https://crrev.com/e16d4aaa97a134e73510e2bce2f99359396f690f Cr-Commit-Position: refs/heads/master@{#428261}

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 16 (9 generated)
yoichio
Created Revert of Content in disabled input field should not be selectable.
4 years, 1 month ago (2016-10-27 02:14:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455853002/1
4 years, 1 month ago (2016-10-27 02:15:05 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/323335)
4 years, 1 month ago (2016-10-27 02:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455853002/140001
4 years, 1 month ago (2016-10-28 02:28:19 UTC) #11
tkent
lgtm
4 years, 1 month ago (2016-10-28 02:33:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 1 month ago (2016-10-28 02:37:52 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:41:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e16d4aaa97a134e73510e2bce2f99359396f690f
Cr-Commit-Position: refs/heads/master@{#428261}

Powered by Google App Engine
This is Rietveld 408576698