Pass task_runner_ to server and send 404 when incorrect url

components/ui_devtools/devtools_server.h

Index: components/ui_devtools/devtools_server.h
diff --git a/components/ui_devtools/devtools_server.h b/components/ui_devtools/devtools_server.h
index a3aa09fcd12750621d578533cd0149909e1df5de..97db1d45d8886f2f28def6db0236644ae12d9148 100644
--- a/components/ui_devtools/devtools_server.h
+++ b/components/ui_devtools/devtools_server.h
@@ -20,16 +20,21 @@ namespace devtools {
 
 class UiDevToolsServer : public net::HttpServer::Delegate {
  public:
-  UiDevToolsServer();
   ~UiDevToolsServer() override;
 
   // Returns an empty unique_ptr if ui devtools flag isn't enabled.
   static std::unique_ptr<UiDevToolsServer> Create();
+  static std::unique_ptr<UiDevToolsServer> Create(
+      scoped_refptr<base::SingleThreadTaskRunner> task_runner);

[sadrul, 2016/10/29 05:39:51]

I would remove the default version (i.e. without param). If the param is null,
then a new thread is created.

[Sarmad Hashmi, 2016/10/29 16:26:19]

Done.

 
   void AttachClient(std::unique_ptr<UiDevToolsClient> client);
   void SendOverWebSocket(int connection_id, const String& message);
 
  private:
+  UiDevToolsServer();
+  explicit UiDevToolsServer(
+      scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+
   void Start(const std::string& address_string, uint16_t port);
   void StartServer(const std::string& address_string, uint16_t port);
 
@@ -47,10 +52,9 @@ class UiDevToolsServer : public net::HttpServer::Delegate {
   ClientsList clients_;
   ConnectionsMap connections_;
 
-  // TODO(mhashmi): Inject IO thread task runner instead of creating/owning
-  // thread
   std::unique_ptr<base::Thread> thread_;
   std::unique_ptr<net::HttpServer> server_;
+  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(UiDevToolsServer);
 };