Pass task_runner_ to server and send 404 when incorrect url

components/ui_devtools/devtools_server.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UI_DEVTOOLS_DEVTOOLS_SERVER_H_
 #define COMPONENTS_UI_DEVTOOLS_DEVTOOLS_SERVER_H_
 
 #include <vector>
 
 #include "base/threading/thread.h"
 #include "components/ui_devtools/DOM.h"
 #include "components/ui_devtools/Forward.h"
 #include "components/ui_devtools/Protocol.h"
 #include "components/ui_devtools/devtools_client.h"
 #include "components/ui_devtools/string_util.h"
 #include "net/server/http_server.h"
 
 namespace ui {
 namespace devtools {
 
 class UiDevToolsServer : public net::HttpServer::Delegate {
  public:
-  UiDevToolsServer();
   ~UiDevToolsServer() override;
 
   // Returns an empty unique_ptr if ui devtools flag isn't enabled.
   static std::unique_ptr<UiDevToolsServer> Create();
+  static std::unique_ptr<UiDevToolsServer> Create(
+      scoped_refptr<base::SingleThreadTaskRunner> task_runner);

[sadrul, 2016/10/29 05:39:51]

I would remove the default version (i.e. without param). If the param is null,
then a new thread is created.

[Sarmad Hashmi, 2016/10/29 16:26:19]

Done.

 
   void AttachClient(std::unique_ptr<UiDevToolsClient> client);
   void SendOverWebSocket(int connection_id, const String& message);
 
  private:
+  UiDevToolsServer();
+  explicit UiDevToolsServer(
+      scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+
   void Start(const std::string& address_string, uint16_t port);
   void StartServer(const std::string& address_string, uint16_t port);
 
   // HttpServer::Delegate
   void OnConnect(int connection_id) override;
   void OnHttpRequest(int connection_id,
                      const net::HttpServerRequestInfo& info) override;
   void OnWebSocketRequest(int connection_id,
                           const net::HttpServerRequestInfo& info) override;
   void OnWebSocketMessage(int connection_id, const std::string& data) override;
   void OnClose(int connection_id) override;
 
   using ClientsList = std::vector<std::unique_ptr<UiDevToolsClient>>;
   using ConnectionsMap = std::map<uint32_t, UiDevToolsClient*>;
   ClientsList clients_;
   ConnectionsMap connections_;
 
-  // TODO(mhashmi): Inject IO thread task runner instead of creating/owning
-  // thread
   std::unique_ptr<base::Thread> thread_;
   std::unique_ptr<net::HttpServer> server_;
+  scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(UiDevToolsServer);
 };
 
 }  // namespace devtools
 }  // namespace ui
 
 #endif  // COMPONENTS_UI_DEVTOOLS_DEVTOOLS_SERVER_H_