Enforce min expected value for CustomCountHistograms on android

Enforce min expected value for CustomCountHistograms on android

BUG=659748
Committed: https://crrev.com/d96ddb18a873f7cfd805abfcfce9ab5ba541857c
Cr-Commit-Position: refs/heads/master@{#428490}

[sebsg, 2016-10-26 21:54:56]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:55:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 23:42:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sebsg, 2016-10-27 17:51:19]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-10-27 17:52:49]

sebsg@chromium.org changed reviewers:
+ dmurph@chromium.org

[sebsg, 2016-10-27 17:52:50]

dmurph@ As mentionned by email, just wanted to make sure you are fine with this.
Thanks!

[sebsg, 2016-10-27 18:08:13]

sebsg@chromium.org changed reviewers:
+ thestig@chromium.org

[sebsg, 2016-10-27 18:08:13]

Hi thestig@, could you please take a look? thanks!

[dmurph, 2016-10-27 18:38:34]

lgtm

[Lei Zhang, 2016-10-27 18:47:13]

On 2016/10/27 18:08:13, sebsg wrote:
> Hi thestig@, could you please take a look? thanks!

Can you ask base/android/OWNERS and chrome/android/OWNERS?

[sebsg, 2016-10-27 18:59:00]

sebsg@chromium.org changed reviewers:
+ agrieve@chromium.org, dfalcantara@chromium.org

[sebsg, 2016-10-27 18:59:01]

agrieve@ could you please take a look at base/android/*

dfalcantara@ could you please take a look at chrome/android/*

Thanks!

[gone, 2016-10-27 21:31:20]

This change breaks ClearBrowsingPreferences#onActivityResult, which has a
minimum of 0.  You need to sort it out with them before enforcing this.

[gone, 2016-10-27 21:31:51]

Oh, of course I didn't see the two liner right after this.  Bah.

[gone, 2016-10-27 21:32:53]

lgtm

https://codereview.chromium.org/2455803002/diff/20001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
(right):

https://codereview.chromium.org/2455803002/diff/20001/base/android/java/src/o...
base/android/java/src/org/chromium/base/metrics/RecordHistogram.java:114: *
@param min lower bound for expected sample values. It must be >= 1
"lower bound for expected sample values, at least 1" to match above?

[agrieve, 2016-10-28 14:55:41]

On 2016/10/27 21:32:53, dfalcantara (slow 10.24) wrote:
> lgtm
> 
>
https://codereview.chromium.org/2455803002/diff/20001/base/android/java/src/o...
> File base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
> (right):
> 
>
https://codereview.chromium.org/2455803002/diff/20001/base/android/java/src/o...
> base/android/java/src/org/chromium/base/metrics/RecordHistogram.java:114: *
> @param min lower bound for expected sample values. It must be >= 1
> "lower bound for expected sample values, at least 1" to match above?

rs lgtm

[sebsg, 2016-10-28 20:32:15]

The CQ bit was checked by sebsg@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 21:11:19]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-28 21:12:58]

Description was changed from

==========
Enforce min expected value for CustomCountHistograms on android

BUG=659748
==========

to

==========
Enforce min expected value for CustomCountHistograms on android

BUG=659748

Committed: https://crrev.com/d96ddb18a873f7cfd805abfcfce9ab5ba541857c
Cr-Commit-Position: refs/heads/master@{#428490}
==========

[commit-bot: I haz the power, 2016-10-28 21:12:59]

Patchset 1 (id:??) landed as
https://crrev.com/d96ddb18a873f7cfd805abfcfce9ab5ba541857c
Cr-Commit-Position: refs/heads/master@{#428490}