[Payments] Fix the Payment Request histogram check failure in tests.

[Payments] Fix the Payment Request histogram check failure in tests.

BUG=659739
Committed: https://crrev.com/fda49ee4f9201fe1190d982fd41a51e5f586e3c1
Cr-Commit-Position: refs/heads/master@{#427887}

[sebsg, 2016-10-26 18:58:44]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-10-26 18:59:32]

sebsg@chromium.org changed reviewers:
+ rouslan@chromium.org

[sebsg, 2016-10-26 18:59:32]

Hi Rouslan, PTAL?

[please use gerrit instead, 2016-10-26 22:01:14]

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
(right):

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java:18:
// The min has to be set to 1 even though we can log 0.
Please explain why min has to be 1 and why can log 0. If there's a bug about
this, you can link to it instead.

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:151:
/* Resets the mUI when doing a second payment request in the same test. */
/** Clicks the HTML node to bring up the UI a second time. */

mUI is more of an implementation detail. Don't put that in comments.

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:155:
clickNodeAndWait(nodeId, (CallbackHelper) helper);
No need to cast PaymentsCallbackHelper to CallbackHelper here. I was doing that
in triggerUIAndWait() because there're several triggerUIAndWait() calls. Some
take PaymentsCallbackHelper and one takes CallbackHelper. I wanted to make sure
that I'm calling the right one. There's only one clickNodeAndWait(). It will be
called no matter what.

[sebsg, 2016-10-26 22:50:52]

Patchset #2 (id:40001) has been deleted

[sebsg, 2016-10-26 23:41:48]

Patchset #2 (id:60001) has been deleted

[sebsg, 2016-10-26 23:42:04]

Thanks! another look?

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java
(right):

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java:18:
// The min has to be set to 1 even though we can log 0.
On 2016/10/26 22:01:14, rouslan wrote:
> Please explain why min has to be 1 and why can log 0. If there's a bug about
> this, you can link to it instead.

Please tell me if this is more clear. I'm making a CL to enforce this.

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:151:
/* Resets the mUI when doing a second payment request in the same test. */
On 2016/10/26 22:01:14, rouslan wrote:
> /** Clicks the HTML node to bring up the UI a second time. */
> 
> mUI is more of an implementation detail. Don't put that in comments.

Done.

https://codereview.chromium.org/2455513004/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:155:
clickNodeAndWait(nodeId, (CallbackHelper) helper);
On 2016/10/26 22:01:14, rouslan wrote:
> No need to cast PaymentsCallbackHelper to CallbackHelper here. I was doing
that
> in triggerUIAndWait() because there're several triggerUIAndWait() calls. Some
> take PaymentsCallbackHelper and one takes CallbackHelper. I wanted to make
sure
> that I'm calling the right one. There's only one clickNodeAndWait(). It will
be
> called no matter what.

Done.

[please use gerrit instead, 2016-10-26 23:44:22]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-10-26 23:44:22]

lgtm

[commit-bot: I haz the power, 2016-10-26 23:45:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:15:24]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-10-27 00:18:14]

Description was changed from

==========
[Payments] Fix the Payment Request histogram check failure in tests.

BUG=659739
==========

to

==========
[Payments] Fix the Payment Request histogram check failure in tests.

BUG=659739

Committed: https://crrev.com/fda49ee4f9201fe1190d982fd41a51e5f586e3c1
Cr-Commit-Position: refs/heads/master@{#427887}
==========

[commit-bot: I haz the power, 2016-10-27 00:18:15]

Patchset 2 (id:??) landed as
https://crrev.com/fda49ee4f9201fe1190d982fd41a51e5f586e3c1
Cr-Commit-Position: refs/heads/master@{#427887}