chromeos/dbus/shill_device_client.cc - Issue 24558004: Track active references in ShillClientHelper (Take 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_device_client.cc

Issue 24558004: Track active references in ShillClientHelper (Take 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_device_client.cc

diff --git a/chromeos/dbus/shill_device_client.cc b/chromeos/dbus/shill_device_client.cc

index 931e71ab3a85bb7164ee0886e8cb43ef8bed0611..5aa433253d34682af181d649245b2ee2d0340f67 100644

--- a/chromeos/dbus/shill_device_client.cc

+++ b/chromeos/dbus/shill_device_client.cc

@@ -215,7 +215,7 @@ class ShillDeviceClientImpl : public ShillDeviceClient {

// There is no helper for the profile, create it.

dbus::ObjectProxy* object_proxy =

bus_->GetObjectProxy(shill::kFlimflamServiceName, device_path);

- ShillClientHelper* helper = new ShillClientHelper(bus_, object_proxy);

+ ShillClientHelper* helper = new ShillClientHelper(object_proxy);

CHECK(helper) << "Unable to create Shill client helper.";

helper->MonitorPropertyChanged(shill::kFlimflamDeviceInterface);

helpers_.insert(HelperMap::value_type(device_path.value(), helper));

« no previous file with comments | « chromeos/dbus/shill_client_helper.cc ('k') | chromeos/dbus/shill_ipconfig_client.cc » ('j') | no next file with comments »