Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2455733004:
Do not show "can't open" dialog when the disambig dialog is dismissed (Closed)
|
Created:
4 years, 1 month ago by Yusuke Sato Modified:
4 years, 1 month ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not show "can't open" dialog when the disambig dialog is dismissed
BUG=b:31959560
TEST=click a link with a custom scheme, then press ESC
Committed: https://crrev.com/f3265229a6aaf877a6fda978003bd3249a8280f6
Cr-Commit-Position: refs/heads/master@{#430306}
Patch Set 1 #Patch Set 2 : rebase #
Total comments: 2
Patch Set 3 : address comment #Messages
Total messages: 23 (15 generated)
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yusukes@chromium.org changed reviewers: + djacobo@google.com, lhchavez@chromium.org
PTAL too.
https://codereview.chromium.org/2455733004/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc (right): https://codereview.chromium.org/2455733004/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc:297: // Once we show the UI, we should never show the Chrome OS' fallback dialog. I think this should be more appropriate on line 214 or 267 since that's the entry point after calling the UI, WDYT?
ptal https://codereview.chromium.org/2455733004/diff/20001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc (right): https://codereview.chromium.org/2455733004/diff/20001/chrome/browser/chromeos... chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc:297: // Once we show the UI, we should never show the Chrome OS' fallback dialog. On 2016/11/05 00:30:27, djacobo wrote: > I think this should be more appropriate on line 214 or 267 since that's the > entry point after calling the UI, WDYT? Done.
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by yusukes@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Do not show "can't open" dialog when the disambig dialog is dismissed BUG=b:31959560 TEST=click a link with a custom scheme, then press ESC ========== to ========== Do not show "can't open" dialog when the disambig dialog is dismissed BUG=b:31959560 TEST=click a link with a custom scheme, then press ESC Committed: https://crrev.com/f3265229a6aaf877a6fda978003bd3249a8280f6 Cr-Commit-Position: refs/heads/master@{#430306} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f3265229a6aaf877a6fda978003bd3249a8280f6 Cr-Commit-Position: refs/heads/master@{#430306} |
