Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

Issue 2455733004: Do not show "can't open" dialog when the disambig dialog is dismissed (Closed)
Patch Set: address comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
index f49f39f6e5b238741031a5bb3addcbba703ad0c2..aaa0d9b294ff6d3d902ce3972aa7d86eddff43b0 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
@@ -211,7 +211,8 @@ bool HandleUrl(int render_process_host_id,
return false;
}
-// Called when the dialog is closed.
+// Called when the dialog is closed. Note that once we show the UI, we should
+// never show the Chrome OS' fallback dialog.
void OnIntentPickerClosed(int render_process_host_id,
int routing_id,
const GURL& url,
@@ -265,9 +266,8 @@ void OnIntentPickerClosed(int render_process_host_id,
// fall through.
}
case ArcNavigationThrottle::CloseReason::DIALOG_DEACTIVATED: {
- // The user didn't select any ARC activity. Show the Chrome OS dialog.
- ShowFallbackExternalProtocolDialog(render_process_host_id, routing_id,
- url);
+ // The user didn't select any ARC activity.
+ CloseTabIfNeeded(render_process_host_id, routing_id);
break;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698