Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2455583002: Revert of Change most IPC tests to use ChannelMojo. (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, fuzzing_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change most IPC tests to use ChannelMojo. (patchset #1 id:100001 of https://codereview.chromium.org/2451953003/ ) Reason for revert: IPCChannelBadMessageTest.BadMessage is failing on Ubuntu-12.04. Original issue's description: > Change most IPC tests to use ChannelMojo. > > Most IPC::Channels in production are now ChannelMojo, but most tests > use the platform-specific Channel implementations. This changes the IPC > tests other than IPCMultiSendingFdsTest.StressTest and those in > ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use > ChannelMojo. > > BUG=659448 > > Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 > Cr-Commit-Position: refs/heads/master@{#427624} TBR=rockot@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=659448 Committed: https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e Cr-Commit-Position: refs/heads/master@{#427642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -510 lines) Patch
M ipc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 31 chunks +131 lines, -41 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 4 chunks +15 lines, -7 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 3 chunks +37 lines, -34 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 60 chunks +270 lines, -264 lines 0 comments Download
M ipc/ipc_test_base.h View 2 chunks +0 lines, -84 lines 0 comments Download
M ipc/ipc_test_base.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
foolip
Created Revert of Change most IPC tests to use ChannelMojo.
4 years, 1 month ago (2016-10-26 08:56:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455583002/1
4 years, 1 month ago (2016-10-26 08:56:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 08:57:54 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:00:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/010a37c4fcb585575418ea0b0c80cdb97e46fe9e
Cr-Commit-Position: refs/heads/master@{#427642}

Powered by Google App Engine
This is Rietveld 408576698