Convert PDF component IPC to mojo.

Convert PDF component IPC to mojo.

Converts the PDF component's IPC messages to Mojo.

BUG=612500
Review-Url: https://codereview.chromium.org/2455543002
Cr-Commit-Position: refs/heads/master@{#461928}
Committed: https://chromium.googlesource.com/chromium/src/+/eb509f59b8e9f31569d0dad0d90d8f755291d497

[benwells, 2016-10-26 04:08:11]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 04:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:13:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 04:13:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[benwells, 2016-10-28 04:42:12]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 04:42:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 05:31:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 05:31:05]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[benwells, 2017-03-22 06:15:44]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 06:16:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 06:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 06:33:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[benwells, 2017-03-22 07:44:27]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 07:44:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 09:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 09:28:30]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-03-23 06:23:50]

benwells@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2017-03-23 23:57:00]

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
File components/pdf/common/OWNERS (left):

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
components/pdf/common/OWNERS:1: per-file *_messages*.h=set noparent
Remove these.

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
File components/pdf/common/pdf.mojom (right):

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
components/pdf/common/pdf.mojom:12: UpdateContentRestrictions(int8
restrictions);
I think int32 is fine.

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
components/pdf/common/pdf.mojom:18: SaveURLAs(url.mojom.Url url,
blink.mojom.Referrer referrer);
While you're here, SaveUrlAs and PdfService.

See https://google.github.io/styleguide/cppguide.html#Function_Names

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/rendere...
File components/pdf/renderer/pepper_pdf_host.cc (right):

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/rendere...
components/pdf/renderer/pepper_pdf_host.cc:121: content::RenderFrame*
render_frame = GetRenderFrame();
This should be inside GetRemotePDFService().

https://codereview.chromium.org/2455543002/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/BUILD.gn (right):

https://codereview.chromium.org/2455543002/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/BUILD.gn:648: "//components/*",
Is this needed?

[benwells, 2017-03-27 06:55:07]

https://codereview.chromium.org/2455543002/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/BUILD.gn (right):

https://codereview.chromium.org/2455543002/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/BUILD.gn:648: "//components/*",
On 2017/03/23 23:57:00, Sam McNally wrote:
> Is this needed?

I'd like to avoid it but not sure how. What should I depend on from the pdf
common BUILD instead? there doesn't appear to anything in
//content/public/common.

[benwells, 2017-03-28 02:51:24]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 02:51:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 04:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:28:27]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-03-29 04:18:06]

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
File components/pdf/common/OWNERS (left):

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
components/pdf/common/OWNERS:1: per-file *_messages*.h=set noparent
On 2017/03/23 23:56:59, Sam McNally wrote:
> Remove these.

Done.

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
File components/pdf/common/pdf.mojom (right):

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/common/...
components/pdf/common/pdf.mojom:18: SaveURLAs(url.mojom.Url url,
blink.mojom.Referrer referrer);
On 2017/03/23 23:57:00, Sam McNally wrote:
> While you're here, SaveUrlAs and PdfService.
> 
> See https://google.github.io/styleguide/cppguide.html#Function_Names

Done.

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/rendere...
File components/pdf/renderer/pepper_pdf_host.cc (right):

https://codereview.chromium.org/2455543002/diff/100001/components/pdf/rendere...
components/pdf/renderer/pepper_pdf_host.cc:121: content::RenderFrame*
render_frame = GetRenderFrame();
On 2017/03/23 23:57:00, Sam McNally wrote:
> This should be inside GetRemotePDFService().

Done.

https://codereview.chromium.org/2455543002/diff/100001/third_party/WebKit/pub...
File third_party/WebKit/public/BUILD.gn (right):

https://codereview.chromium.org/2455543002/diff/100001/third_party/WebKit/pub...
third_party/WebKit/public/BUILD.gn:648: "//components/*",
On 2017/03/27 06:55:07, benwells wrote:
> On 2017/03/23 23:57:00, Sam McNally wrote:
> > Is this needed?
> 
> I'd like to avoid it but not sure how. What should I depend on from the pdf
> common BUILD instead? there doesn't appear to anything in
> //content/public/common.

Done.

[Sam McNally, 2017-03-29 04:35:35]

lgtm

https://codereview.chromium.org/2455543002/diff/120001/third_party/WebKit/pub...
File third_party/WebKit/public/BUILD.gn (right):

https://codereview.chromium.org/2455543002/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/BUILD.gn:648: "//components/*",
Why are these still here?

[benwells, 2017-03-31 07:19:23]

https://codereview.chromium.org/2455543002/diff/120001/third_party/WebKit/pub...
File third_party/WebKit/public/BUILD.gn (right):

https://codereview.chromium.org/2455543002/diff/120001/third_party/WebKit/pub...
third_party/WebKit/public/BUILD.gn:648: "//components/*",
On 2017/03/29 04:35:35, Sam McNally wrote:
> Why are these still here?

Oops, removed.

[benwells, 2017-03-31 07:20:41]

benwells@chromium.org changed reviewers:
+ dsinclair@chromium.org

[benwells, 2017-03-31 07:21:36]

oops, forgot message.

+dsinclair for general PDF onwers review before sending to security and WebKit
owners.

[benwells, 2017-04-03 03:02:39]

On 2017/03/31 07:21:36, benwells wrote:
> oops, forgot message.
> 
> +dsinclair for general PDF onwers review before sending to security and WebKit
> owners.

ping dsinclair

[dsinclair, 2017-04-03 13:23:00]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2017-04-03 13:23:01]

https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
File components/pdf/browser/pdf_web_contents_helper.h (right):

https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
components/pdf/browser/pdf_web_contents_helper.h:47: 
nit: no blank link

https://codereview.chromium.org/2455543002/diff/160001/components/pdf/common/...
File components/pdf/common/BUILD.gn (right):

https://codereview.chromium.org/2455543002/diff/160001/components/pdf/common/...
components/pdf/common/BUILD.gn:14: "//third_party/WebKit/public:mojo_bindings",
Why does pdf depend on webkit?

[Tom Sepez, 2017-04-03 16:53:12]

Messages themselves seem fine, but maybe the referrer has to come out of the
webkit layer ?

[benwells, 2017-04-04 01:19:46]

On 2017/04/03 13:23:01, dsinclair wrote:
>
https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
> File components/pdf/browser/pdf_web_contents_helper.h (right):
> 
>
https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
> components/pdf/browser/pdf_web_contents_helper.h:47: 
> nit: no blank link
> 
>
https://codereview.chromium.org/2455543002/diff/160001/components/pdf/common/...
> File components/pdf/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2455543002/diff/160001/components/pdf/common/...
> components/pdf/common/BUILD.gn:14:
"//third_party/WebKit/public:mojo_bindings",
> Why does pdf depend on webkit?

As Tom mentions it's for referrer, which at the moment is defined in WebKit.

[dsinclair, 2017-04-04 01:26:26]

pdf lgtm

[benwells, 2017-04-04 01:38:17]

benwells@chromium.org changed reviewers:
+ noel@chromium.org

[benwells, 2017-04-04 01:38:19]

+noel for third_party/WebKit/platform owner
tsepez for content/, ipc/ and security review

https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
File components/pdf/browser/pdf_web_contents_helper.h (right):

https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
components/pdf/browser/pdf_web_contents_helper.h:47: 
On 2017/04/03 13:23:01, dsinclair wrote:
> nit: no blank link

Done.

[benwells, 2017-04-04 01:38:45]

On 2017/04/04 01:38:19, benwells wrote:
> +noel for third_party/WebKit/platform owner
> tsepez for content/, ipc/ and security review
oops, i mean toos/ipc_fuzzer, not ipc/

> 
>
https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
> File components/pdf/browser/pdf_web_contents_helper.h (right):
> 
>
https://codereview.chromium.org/2455543002/diff/160001/components/pdf/browser...
> components/pdf/browser/pdf_web_contents_helper.h:47: 
> On 2017/04/03 13:23:01, dsinclair wrote:
> > nit: no blank link
> 
> Done.

[Noel Gordon, 2017-04-04 05:02:38]

Platform LGTM.

[Tom Sepez, 2017-04-04 16:41:53]

lgtm

[benwells, 2017-04-04 22:47:39]

The CQ bit was checked by benwells@chromium.org

[benwells, 2017-04-04 22:47:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org,
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2455543002/#ps200001
(title: "Feedback")

[commit-bot: I haz the power, 2017-04-04 22:48:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 01:06:31]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1491346059434880,
"parent_rev": "a71920e629d8d02ce7bec68dc9b485e43507849e", "commit_rev":
"eb509f59b8e9f31569d0dad0d90d8f755291d497"}

[commit-bot: I haz the power, 2017-04-05 01:07:22]

Description was changed from

==========
Convert PDF component IPC to mojo.

Converts the PDF component's IPC messages to Mojo.

BUG=612500
==========

to

==========
Convert PDF component IPC to mojo.

Converts the PDF component's IPC messages to Mojo.

BUG=612500

Review-Url: https://codereview.chromium.org/2455543002
Cr-Commit-Position: refs/heads/master@{#461928}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb509f59b8e9f31569d0dad0d90d...
==========

[commit-bot: I haz the power, 2017-04-05 01:07:23]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/eb509f59b8e9f31569d0dad0d90d...