[ios] Adds VoiceSearchBar creation methods to VoiceSearchProvider.

[ios] Adds VoiceSearchBar creation methods to VoiceSearchProvider.

BUG=656617
Committed: https://crrev.com/e716b15586e831dd2939fd301127e7398f71ad03
Cr-Commit-Position: refs/heads/master@{#428076}

[rohitrao (ping after 24h), 2016-10-27 15:32:13]

rohitrao@chromium.org changed reviewers:
+ sdefresne@chromium.org

[rohitrao (ping after 24h), 2016-10-27 16:54:38]

rohitrao@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[rohitrao (ping after 24h), 2016-10-27 16:54:38]

+kkhorimoto

[kkhorimoto, 2016-10-27 17:22:48]

lgtm

https://codereview.chromium.org/2455503007/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/voice/voice_search_provider.h (right):

https://codereview.chromium.org/2455503007/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/voice/voice_search_provider.h:41:
NS_RETURNS_RETAINED;
is NS_RETURNS_RETAINED an ARC-related annotation?  It might be worthwhile
sending out a PSA on when to use these for interfacing between C++ and ARC code

[rohitrao (ping after 24h), 2016-10-27 17:47:29]

https://codereview.chromium.org/2455503007/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/voice/voice_search_provider.h (right):

https://codereview.chromium.org/2455503007/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/voice/voice_search_provider.h:41:
NS_RETURNS_RETAINED;
On 2016/10/27 17:22:47, kkhorimoto_ wrote:
> is NS_RETURNS_RETAINED an ARC-related annotation?  It might be worthwhile
> sending out a PSA on when to use these for interfacing between C++ and ARC
code

I've been cargo-culting it.  Will check with stk about sending out a PSA.  I
think it's helpful for him as he manually migrates files, but it may not
directly affect correctness?

[rohitrao (ping after 24h), 2016-10-27 17:47:47]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:48:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:03:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-27 18:30:39]

Description was changed from

==========
[ios] Adds VoiceSearchBar creation methods to VoiceSearchProvider.

BUG=656617
==========

to

==========
[ios] Adds VoiceSearchBar creation methods to VoiceSearchProvider.

BUG=656617

Committed: https://crrev.com/e716b15586e831dd2939fd301127e7398f71ad03
Cr-Commit-Position: refs/heads/master@{#428076}
==========

[commit-bot: I haz the power, 2016-10-27 18:30:40]

Patchset 1 (id:??) landed as
https://crrev.com/e716b15586e831dd2939fd301127e7398f71ad03
Cr-Commit-Position: refs/heads/master@{#428076}

[sdefresne, 2016-10-28 11:41:42]

On 2016/10/27 17:47:29, rohitrao wrote:
>
https://codereview.chromium.org/2455503007/diff/1/ios/public/provider/chrome/...
> File ios/public/provider/chrome/browser/voice/voice_search_provider.h (right):
> 
>
https://codereview.chromium.org/2455503007/diff/1/ios/public/provider/chrome/...
> ios/public/provider/chrome/browser/voice/voice_search_provider.h:41:
> NS_RETURNS_RETAINED;
> On 2016/10/27 17:22:47, kkhorimoto_ wrote:
> > is NS_RETURNS_RETAINED an ARC-related annotation?  It might be worthwhile
> > sending out a PSA on when to use these for interfacing between C++ and ARC
> code
> 
> I've been cargo-culting it.  Will check with stk about sending out a PSA.  I
> think it's helpful for him as he manually migrates files, but it may not
> directly affect correctness?

It does affect correctness. Without this annotation, ARC assumes that the caller
does not owns the returned reference (see
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Me...)
and will not call release on it thus causing a leak.

It is only important if the caller or callee is compiled with ARC while the
other is not. If both are compiled with ARC or without ARC, then it is not
really an issue (as the refcount is either not managed by ARC or fully managed
by ARC).