Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ios/public/provider/chrome/browser/voice/voice_search_provider.h

Issue 2455503007: [ios] Adds VoiceSearchBar creation methods to VoiceSearchProvider. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/voice/voice_search_provider.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/public/provider/chrome/browser/voice/voice_search_provider.h
diff --git a/ios/public/provider/chrome/browser/voice/voice_search_provider.h b/ios/public/provider/chrome/browser/voice/voice_search_provider.h
index 98890042ad367dd0ee36a524dc41d51d86700ff1..3391e10350882aee9c0e83a8cc3c1b1983baaee2 100644
--- a/ios/public/provider/chrome/browser/voice/voice_search_provider.h
+++ b/ios/public/provider/chrome/browser/voice/voice_search_provider.h
@@ -6,11 +6,13 @@
#define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_PROVIDER_H_
#include <Foundation/Foundation.h>
+#include <UIKit/UIKit.h>
#include "base/macros.h"
#include "base/memory/ref_counted.h"
class AudioSessionController;
+@protocol VoiceSearchBar;
class VoiceSearchController;
namespace ios {
@@ -34,6 +36,10 @@ class VoiceSearchProvider {
virtual scoped_refptr<VoiceSearchController> CreateVoiceSearchController(
ios::ChromeBrowserState* browser_state) const;
+ // Creates a new VoiceSearchBar. The caller assumes ownership.
+ virtual UIView<VoiceSearchBar>* CreateVoiceSearchBar(CGRect frame) const
+ NS_RETURNS_RETAINED;
kkhorimoto 2016/10/27 17:22:47 is NS_RETURNS_RETAINED an ARC-related annotation?
rohitrao (ping after 24h) 2016/10/27 17:47:28 I've been cargo-culting it. Will check with stk a
+
private:
DISALLOW_COPY_AND_ASSIGN(VoiceSearchProvider);
};
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/voice/voice_search_provider.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698