Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2455493002: service worker: Propagate navigation preload flag to SWVersion. (Closed)

Created:
4 years, 1 month ago by falken
Modified:
4 years, 1 month ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Propagate navigation preload flag to SWVersion. The source of truth of navigation preload state is SWRegistration. But we must look up the state quickly given a SWVersion, and there is not necessarily a live registration when there is a live version. So this patch sets and maintains the flag on the active version of the registration. BUG=649558 Committed: https://crrev.com/4aa66f50558f4c5761f5cec0f0c47ee90079ae12 Cr-Commit-Position: refs/heads/master@{#427641}

Patch Set 1 #

Patch Set 2 : more comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_registration.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
falken
ptal
4 years, 1 month ago (2016-10-26 02:22:30 UTC) #3
horo
lgtm
4 years, 1 month ago (2016-10-26 05:34:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455493002/20001
4 years, 1 month ago (2016-10-26 07:49:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 08:53:52 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 08:55:29 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4aa66f50558f4c5761f5cec0f0c47ee90079ae12
Cr-Commit-Position: refs/heads/master@{#427641}

Powered by Google App Engine
This is Rietveld 408576698